Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cpp11::(tuple|get) #4774

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Remove cpp11::(tuple|get) #4774

merged 5 commits into from
Jun 23, 2020

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Jun 9, 2020

Summary of Changes

Remove cpp11. And use #ifdef CGAL_NO_DEPRECATED_CODE around the backward
compatibility code in <CGAL/config.h>.

See also: #4775 (same PR for CGAL-5.0.x)

Release Management

  • Affected package(s): CMap, Spatial_searching, Surface_mesh_topology

@sloriot
Copy link
Member

sloriot commented Jun 9, 2020

Note that you could even have applied it to the 5.0 branch but it is not that important. (Anyway it might have been introduced with the Surface_mesh_topology package).

And use `#ifdef CGAL_NO_DEPRECATED_CODE` around the backward
compatibility code in `<CGAL/config.h>`.
And use `#ifdef CGAL_NO_DEPRECATED_CODE` around the backward
compatibility code in `<CGAL/config.h>`.
@lrineau
Copy link
Member Author

lrineau commented Jun 9, 2020

Note that you could even have applied it to the 5.0 branch but it is not that important. (Anyway it might have been introduced with the Surface_mesh_topology package).

Done in #4775, and I have modified the history of this PR to merge the other one.

@lrineau
Copy link
Member Author

lrineau commented Jun 10, 2020

@maxGimeno You should test #4775 instead of this one (#4774).

@maxGimeno
Copy link
Contributor

Oops, yes indeed

@lrineau
Copy link
Member Author

lrineau commented Jun 11, 2020

@maxGimeno You should test #4775 instead of this one (#4774).

Actually, I wrote it the wrong way: we should test this one (#4774) instead of #4775.

@maxGimeno
Copy link
Contributor

Oh

@lrineau
Copy link
Member Author

lrineau commented Jun 12, 2020

Fixed in 8205112.

@maxGimeno
Copy link
Contributor

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 23, 2020
@lrineau lrineau merged commit dad9db1 into CGAL:master Jun 23, 2020
@lrineau lrineau deleted the CGAL-remove_cpp11-GF branch June 23, 2020 17:01
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 23, 2020
@lrineau lrineau mentioned this pull request Sep 10, 2020
89 tasks
@lrineau lrineau mentioned this pull request Jun 2, 2021
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants