Add "binary" expression in file open of registration_with_OpenGR example #5290
Conversation
`data/hippo1.ply` and `data/hippo2.ply` are in binary_little_endian format. So `read_ply_points` can't read them if they aren't opened in binary mode. Also add a specific error if a file can't be open and a new argument to pass the output filename
Add the ```c++ input.open(fname_in2, std::ios::binary); ``` expression in `registration_with_pointmatcher` and `registration_with_opengr_pointmatcher_pipeline` examples
There was a problem hiding this comment.
I agree with the proposed change (adding the std::ios::binary tag) but the diff is way too large for such a small change. Please rewrite your commit without reindenting the whole files you modify (and please use spaces and not tabs for consistency with the rest of the files).
MaelRL
added
the
Not yet approved
|
I have revert my changes and only add the |
|
@maxGimeno If you change the milestone to 5.3, the PR loses its purpose since this was fixed in the IO PR already. |
As the base branch of the PR includes commits from |
|
#5323 has the same diff, but targets 5.1. This PR can probably be closed. |
|
Sorry, I completely forgot about this PR, it could also have been rebased… |
|
Replaced by #5323. |
MaelRL
added
Replaced
and removed
Not yet approved
Summary of Changes
registration_with_OpenGRexample can't be compilled without this small change:std::ifstream input(fname_in1);to
std::ifstream input(fname_in1, std::ios::binary);data/hippo1.plyanddata/hippo2.plyare in binary_little_endian format. Soread_ply_pointscan't read them if they aren't opened in binary mode.Also add a specific error if a file can't be open and a new argument to pass the output filename
Release Management