Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinetic Shape Partition #7198

Merged
merged 532 commits into from
May 26, 2024
Merged

Kinetic Shape Partition #7198

merged 532 commits into from
May 26, 2024

Conversation

soesau
Copy link
Member

@soesau soesau commented Jan 18, 2023 •
edited by sloriot
Loading

PR for Kinetic Partitioning and Reconstruction feature.

  • Affected package(s): Kinetic Partitioning and Reconstruction
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any): link
  • Link to compiled documentation: link
  • License and copyright ownership: GeometryFactory/Inria

TODO:

danston and others added 30 commits August 6, 2021 16:33
@danston
Merge remote-tracking branch 'origin/master' into Kinetic_shape_recon…
36a8bcc 
…struction-new_package-danston
@danston
better handle reversed case
3fe9502
@danston
updated todo + 3d test
35a60ff
@danston
updated test cases
65450a5
@danston
added new test files
505a301
@danston
updated todo
9dd5e72
@danston
Merge remote-tracking branch 'origin/master' into Kinetic_shape_recon…
e155a0c 
…struction-new_package-danston
@danston
update shape regularization call
10ea9c3
@danston
fixed bug with nullptr when using epeck
fd7691d
@danston
renamed test files
faf5311
@danston
Merge remote-tracking branch 'origin/master' into Kinetic_shape_recon…
87c6631 
…struction-new_package-danston
@danston
putting all parameters in common struct
acb8bae
@danston
updated todo + added cr
0274b9d
@danston
putting intersections inside kinetic traits
b0cb91d
@danston
adding hybrid mode to intersections
6380042
@danston
remove wall and wextra internal flags
df9d3d2
@danston
fix template word errors
008ea59
@danston
fixed vc++ error with auto for boost function output iterator
c5fa810
@danston
removed wrong path
ba876b7
@danston
fixed some things related to the reconstruction example
93aa513
@danston
cleanup all
5a050f5
@afabri
Fix some warnings
0dd0754
@afabri
Fix some warnings
63f7aaa
@danston
updated reconstruction example
1feb630
@danston
added simple readme
5365e50
@danston
Merge remote-tracking branch 'origin/master' into Kinetic_shape_recon…
2b2d0a7 
…struction-new_package-danston
@danston
removed experimental setup for hybrid mode
9b03377
@danston
updated readme and little cleanup
9502c50
@danston
updated readme
3754f24
@danston
updated readme, todo, and cleanup + more comments
cc80cfb
@sloriot sloriot added Tested and removed Not yet approved The feature or pull-request has not yet been approved. Under Testing labels May 15, 2024
@sloriot
Copy link
Member

sloriot commented May 15, 2024

Successfully tested in CGAL-6.0-Ic-242

@sloriot sloriot force-pushed the Kinetic_shape_reconstruction-new_package-soesau branch from 5c59f58 to 8a1a7f6 Compare May 15, 2024 15:59
@github-actions github-actions bot removed the Tested label May 15, 2024
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@lrineau lrineau self-assigned this May 16, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 16, 2024
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 17, 2024
@soesau
Copy link
Member Author

soesau commented May 21, 2024

/build:v1

@github-actions GitHub Actions
Copy link

There was an error while building the doc:

This round already exists. Overwrite it with /force-build.

https://github.com/CGAL/cgal/actions/runs/9170483968

@soesau
Copy link
Member Author

soesau commented May 21, 2024

/force-build:v1

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7198/v1/Manual/index.html

@lrineau lrineau added the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label May 21, 2024
@albert-github albert-github mentioned this pull request May 24, 2024
Merged
@sloriot
Copy link
Member

sloriot commented May 26, 2024

Successfully tested in CGAL-6.0-Ic-251

@sloriot sloriot merged commit 596fa09 into CGAL:master May 26, 2024
9 checks passed
@sloriot sloriot deleted the Kinetic_shape_reconstruction-new_package-soesau branch October 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau left review comments

@albert-github albert-github albert-github left review comments

@afabri afabri afabri left review comments

Assignees

@lrineau lrineau

Labels
Accepted feature Feature Merged_in_6.0 rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
7 participants
@soesau @lrineau @afabri @sloriot @albert-github @MaelRL @danston