-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log): move processing info log to debug level, add builder log #43
base: main
Are you sure you want to change the base?
Conversation
youen
commented
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This demo need to be updated https://github.com/CGI-FR/PIMO/tree/main/demo/demo9
- CHANGELOG
pkg/model/model.go
Outdated
@@ -24,11 +24,13 @@ import ( | |||
// MaskEngine is a masking algorithm | |||
type MaskEngine interface { | |||
Mask(Entry, ...Dictionary) (Entry, error) | |||
Name() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Name is not the good name... String()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, signature String() string
if you want to implement the fmt.Stringer interface (and then get compatibility with all method from fmt package)
Be careful to not use fmt.Printf("%v", mask)
inside String() string
because you will have an infinite loop
Maybe instead of
use
Because there is a mask named Add and it can be confusing ? |