Fixes CSS preprocessor #21
Conversation
| EOL; | ||
|
|
||
| $myFile = "out"; | ||
| $fh = fopen($myFile, 'w') or die("can't open file"); |
There was a problem hiding this comment.
You should never call die in a unit test, because it causes PHPUnit for exit instantly, and tests that would be run afterwards don't get run. You also don't get any PHPUnit output and an exit code of 0, which is not very helpful for CI systems.
If you've to, then use return $this->fail("can't open file") instead. But I assume this is test code which was accidentally left in, so it would be better to simply remove it.
There was a problem hiding this comment.
Thanks!! Still picking up some php. (I'm a rubyist). I've been really impressed by the tools that have sprung up in the last few years. It's definitely not the PHP I learned 15 years ago :)
|
Apart from a nitty gritty detail, this PR is fine 😄. Thanks for the great work! |
|
Agh, I meant to delete that debug output. I'll do so later. |
|
No problem, I've already done that 😄 |
Hey @CHH - When playing with PIPE today I found I couldn't get CSS directives to work at all. (I'm on PHP 5.3.16 if it matters)
The culprit was a mistake in a regular expression that accounts for multi-line statements. I fixed that (small change) and found that the resulting header had a bunch of blank lines in it. I'm stripping them out too. Finally, I added a new unit test to cover the bug.
Cheers!
Brian