Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates path to autoload.php #25

Merged
merged 2 commits into from
Sep 11, 2012
Merged

Updates path to autoload.php #25

merged 2 commits into from
Sep 11, 2012

Conversation

svperfecta
Copy link
Contributor

When loaded with composer, bin symlinks are setup in vendor/bin (where vendor can be changed based on composers config.) Thus, I think we want to load autoload.php relative to the location of the bin symlink. We also don't want to reference the vendor folder itself.

@CHH
Copy link
Owner

CHH commented Sep 10, 2012

Maybe we could do it in a similar way as Composer, which includes either the local autoloader in ../vendor when the library is checked out standalone or uses the autoloader of the project it's installed in.

This way the users can choose to checkout only Pipe when they just want to use pipe-server or pipe-compile.

See https://github.com/composer/composer/blob/master/src/bootstrap.php in composer for some guidance.

@CHH
Copy link
Owner

CHH commented Sep 10, 2012

BTW, the build is not really failing for this change — it's just Travis having some issues apparently.

@svperfecta
Copy link
Contributor Author

Good idea. I'll take a look at this today.

@svperfecta
Copy link
Contributor Author

Try this @CHH. Should take care of it.

CHH added a commit that referenced this pull request Sep 11, 2012
Updates path to autoload.php
@CHH CHH merged commit 3defe77 into CHH:master Sep 11, 2012
@CHH
Copy link
Owner

CHH commented Sep 11, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants