-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-release fixes #113
pre-release fixes #113
Conversation
franz
commented
Aug 17, 2022
•
edited
Loading
edited
- adds documentation
- adds some missing implementations in bitcode library
- removes doxygen documentation, instead adds a CMake target "gendocs" to generate it
https://chip-spv.github.io/chip-spv/ depends on having the documents built |
Some tests are disabled which now pass |
@@ -92,15 +116,14 @@ set(SAMPLES | |||
11_device | |||
hipStreamSemantics | |||
hipKernelLaunchIsNonBlocking | |||
#hipMultiThreadAddCallback | |||
hipMultiThreadAddCallback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sample can be removed now
It would be great if you could break this PR into something more manageable. For example, make the license texts as a separate one. Currently, this PR is so big that my browser fails to render. Perhaps just reverting the |
Shouldn't GaTech be added to the authors, if code was taken from HIPLZ. |
87725d9
to
b3135cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things are outdated in regards to disabling tests.
Callbacks are disabled even though they should be fixed now.
A lot of tests that do fail and are known to fail are not disabled.
A few other small things.
Failing tests are now disabled by default. They can be enabled at cmake time with cmake option -DENABLE_FAILING_TESTS Tests that don't compile (currently mainly from samples/cuda-samples/ are also disabled by default. They can be enabled with -DENABLE_UNCOMPILABLE_TESTS cmake option.
don't allocate buffers on each iteration
@franz you mentioned that you will split this PR to open another one exclusively for labelling tests. Could you please do that or at least share the mechanism by which we will be disabling tests. Working on a PR where I am resolving a lot of failing tests it would be great to have these labels in place |
@pvelesko sure, it's in branch |
@pvelesko ... commit "CMake check target: add a list of failing HIP tests as regexp" is the one that adds the regexp to disable unit tests. |
Not from my end. It still shown as being in |
I don't know why it's still showing |
You're supposed to re-request review. Let me run the unit tests and I'll approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hipMultiThreadAddCallback (Not Run) ?
Not sure why the unit tests are conflicting perhaps the base is out of date with main?
Other than that, please review if all the tests pass as expected.
level0_unit_tests_iris.log
Outdated
619 - Stress_hipMemcpy_multiDevice-AllAPIs - size_t (Failed) | ||
620 - Stress_hipMemcpy_multiDevice-AllAPIs - long double (Failed) | ||
648 - hipMultiThreadAddCallback (Not Run) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not run? @franz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the logfile in the repository, or is that from an actual ctest
run ? I have checked (by running the tests) and it's enabled. I don't generally update the logfile in the repo as i don't have either of iris / arcticus hardware.