Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ibtypee typo bug in map_mesh_properties #298

Conversation

tgasher
Copy link
Contributor

@tgasher tgasher commented Aug 11, 2023

An incorrect reference to ibtype causes an error. It's within code working on the open boundaries, so it appears it should be ibtypee. Changing it fixed the error, in my case. Though I'm unsure what test cases to compare with, since this seems to be a segment of code that's not been touched before.

An incorrect reference to ibtype causes an error.  It's within code working on the open boundaries, so it appears it should be ibtypee.
Copy link
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding. Looks good

Copy link
Collaborator

@WPringle WPringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to changelog in README

@tgasher
Copy link
Contributor Author

tgasher commented Aug 11, 2023

Done.

@WPringle
Copy link
Collaborator

Done.

Cheers!

@WPringle WPringle merged commit f0c9257 into CHLNDDEV:Projection Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants