Fix to driver history

[dabail10]

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

• Short (1 sentence) summary of your PR:
  Fix from @cmbitz for Issue bug in icedrv_history.F90 regarding trcrn #420.
• Developer(s):
  @dabail10 (D. Bailey)
• Suggest PR reviewers from list in the column to the right.
• Please copy the PR test results link or provide a summary of testing completed below.

There are some missing baselines for PGI here.
MISS cheyenne_pgi_smoke_col_1x1_diag1_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_bgcispol_debug compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_bgcnice_debug compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_bgcsklnice_debug compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_debug_run1year_thermo1 compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_debug_run1year_swredist compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_debug_run1year_swccsm3 compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_alt01_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_alt02_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_alt03_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_alt04_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS cheyenne_pgi_smoke_col_1x1_debug_dt30min_leap_run1year compare icepack.8f96707a90.221210-095008 missing-data
MISS - comparison data is missing
13 of 495 tests MISSING data

https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash#8f96707a90132ca119d81ed84e5a62ca0ff3ed96

• How much do the PR code changes differ from the unmodified code?
  • bit for bit
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on CICE or any other models?
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No
• Please provide any additional information or relevant details below:

[eclare108213]

Did you confirm that the history output for all variables except FSD remains the same as before?

[eclare108213]

does this change only impact FSD output?

[cmbitz]

It impacts all the variables in trcrn, which includes many other tracers. All of them are currently set to -9999 in the history file, even without the FSD. I did not verify that all other variables besides trcrn are unchanged. I'll do that later this afternoon.

[dabail10]

The log files were bfb.

[eclare108213]

The log files were bfb.

Yes, but this changes the history output. Does it look right?

[dabail10]

I will run an io_suite.

[dabail10]

I have confirmed that trcrn now has valid values where it had -9999 before.

[eclare108213]

Excellent. Thank you both, @cmbitz and @dabail10, for fixing this bug.

[apcraig]

Do we need a similar fix in CICE?

[dabail10]

I do not believe so. We do not dump the whole trcr/trcrn array in CICE like we do in Icepack.

[dabail10]

This should be good to go.