Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Overlaps #11

Closed
alexanderigeorgiev opened this issue Jun 15, 2022 · 4 comments
Closed

Package Overlaps #11

alexanderigeorgiev opened this issue Jun 15, 2022 · 4 comments

Comments

@alexanderigeorgiev
Copy link

Hello,
We are using groovy console version 17.0.0 on AEM as a Cloud Service.
The pipeline execution includes some code scanning and one of its findings is this one:

File: org.cid15.aem.groovy.console:aem-groovy-console-ui.config:17.0.0
Issue: affected path /apps/groovyconsole/osgiconfig overlaps [aem-groovy-console:aem-groovy-console-ui.apps:17.0.0]
Adobe rule Package Overlaps is explained here https://experienceleague.adobe.com/docs/experience-manager-cloud-manager/using/how-to-use/custom-code-quality-rules.html?lang=en#oakpal-no-overlap (https://www.adobe.com/go/aem_cmcq_packageoverlaps_en)

In summary two packages aem-groovy-console-ui.config and aem-groovy-console-ui.apps are both writing to /apps/groovyconsole/osgiconfig. That should not happen.

Is is possible that this is fixed in some of the upcoming releases?

@Narendiran100
Copy link

Any update on this

@kwin
Copy link

kwin commented Jan 25, 2024

You should consider switching to the maintained fork at https://github.com/orbinson/aem-groovy-console/tree/main which has this issue (and several others) fixed.

@alexanderigeorgiev
Copy link
Author

alexanderigeorgiev commented Jan 26, 2024 via email

@markdaugherty
Copy link
Contributor

Fixed in 18.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants