Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs with desc #156

merged 33 commits into from Sep 4, 2019


Copy link

commented Sep 3, 2019

Fix for #144: updated to pull data model descriptions from corresponding documentation.

roshni-b and others added 19 commits Aug 26, 2019

@roshni-b roshni-b requested a review from jim-bo Sep 3, 2019


This comment has been minimized.

Copy link

commented Sep 3, 2019

@roshni-b looks good. We want this PR to master to have the PBMC changes we previously had made however.

  1. Can you move "cimac aliquot id" from the filled by CIMAC section to Data Columns under sample source

  2. Remove "lead organization study id" under filled by biorepository.

roshni-b added 5 commits Sep 4, 2019
jim-bo approved these changes Sep 4, 2019
Copy link

left a comment

looks good!

@roshni-b roshni-b merged commit 4df8d8b into master Sep 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.