Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs with desc #156

Merged
merged 33 commits into from Sep 4, 2019
Merged

Updated docs with desc #156

merged 33 commits into from Sep 4, 2019

Conversation

roshni-b
Copy link
Contributor

@roshni-b roshni-b commented Sep 3, 2019

Fix for #144: updated generate_docs.py to pull data model descriptions from corresponding documentation.

@roshni-b roshni-b requested a review from jim-bo September 3, 2019 17:35
@jim-bo
Copy link
Contributor

jim-bo commented Sep 3, 2019

@roshni-b looks good. We want this PR to master to have the PBMC changes we previously had made however.

  1. Can you move "cimac aliquot id" from the filled by CIMAC section to Data Columns under sample source

  2. Remove "lead organization study id" under filled by biorepository.

Copy link
Contributor

@jim-bo jim-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@roshni-b roshni-b merged commit 4df8d8b into master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants