Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a mif unit test, and edited template #91

Merged
merged 2 commits into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@dnunes88
Copy link
Contributor

commented Jul 3, 2019

Added a mif unit test, and edited mif template. Minor naming convention change in mif_input, as well as added a required field.

@dnunes88 dnunes88 requested a review from jim-bo Jul 3, 2019

@jim-bo

jim-bo approved these changes Jul 8, 2019

Copy link
Contributor

left a comment

@dnunes88 looks good, but we have to standardize on a style for formatting the code. A lot of these changes are due to changes in tab convention. We can fix in a little across the project/

@jim-bo jim-bo merged commit 1fc2248 into master Jul 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jim-bo jim-bo deleted the mif_assay_revamps_edits branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.