Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a mif unit test, and edited template #91

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Added a mif unit test, and edited template #91

merged 2 commits into from
Jul 8, 2019

Conversation

dnunes88
Copy link
Contributor

@dnunes88 dnunes88 commented Jul 3, 2019

Added a mif unit test, and edited mif template. Minor naming convention change in mif_input, as well as added a required field.

@dnunes88 dnunes88 requested a review from jim-bo July 3, 2019 15:33
jim-bo
jim-bo approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@jim-bo jim-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnunes88 looks good, but we have to standardize on a style for formatting the code. A lot of these changes are due to changes in tab convention. We can fix in a little across the project/

@jim-bo jim-bo merged commit 1fc2248 into master Jul 8, 2019
@jim-bo jim-bo deleted the mif_assay_revamps_edits branch July 8, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-bo jim-bo jim-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnunes88 @jim-bo