This repository has been archived by the owner on May 27, 2020. It is now read-only.
Domain model dsl language enhancements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purple52
suggested changes
Jan 4, 2018
pom.xml
Outdated
| @@ -30,23 +30,38 @@ | |||
| <id>dsl-domain</id> | |||
| <activation> | |||
| <file> | |||
| <exists>src/test/resources/domain-features/</exists> | |||
| <exists>src/main/resources/domain-features/</exists> | |||
There was a problem hiding this comment.
Why has this moved to main from test? We wouldn't want the feature files to be packaged in the main artifact.
|
|
||
| Given multiple things happened | ||
| When you doSomethingTwice on a StatefulAggregate using an argsA | ||
| Then multiple things happened |
There was a problem hiding this comment.
Do we have some tests that show comma separated events and the use of "And"?
benouaer
force-pushed
the
domain-model-dsl-language-enhancements
branch
from
614de71
to
af131b0
Compare
benouaer
force-pushed
the
domain-model-dsl-language-enhancements
branch
from
af131b0
to
88c8bec
Compare
benouaer
force-pushed
the
domain-model-dsl-language-enhancements
branch
from
88c8bec
to
540f406
Compare
purple52
approved these changes
Jan 11, 2018
This was referenced Jan 11, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
language enhancements for the domain testing DSL
the enhancements are based on these issues