TP-1103 Add JMX support for shutterable and catchup services #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapingo
suggested changes
Feb 15, 2019
| @@ -11,6 +11,12 @@ | |||
|
|
|||
| <artifactId>subscription-manager</artifactId> | |||
|
|
|||
| <properties> | |||
| <org.jboss.arquillian.junit.version>1.0.0.CR7</org.jboss.arquillian.junit.version> | |||
| <org.jboss.arquillian.spi.version>1.0.0.Alpha5</org.jboss.arquillian.spi.version> | |||
There was a problem hiding this comment.
Are these properties needed?
| <version>${test-utils.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <groupId>org.mockito</groupId> |
There was a problem hiding this comment.
looks like there is an issue with the spacing from here onwards
| } | ||
|
|
||
| @Test | ||
| public void shouldTrowExceptionWhenMBeanUnregisteringIncorrect() throws Exception { |
There was a problem hiding this comment.
method name "Trow" should be "Throw"
| } | ||
|
|
||
| @Test | ||
| public void shouldTrowExceptionWhenMBeanRegisteringIncorrect() throws Exception { |
There was a problem hiding this comment.
method name "Trow" should be "Throw"
| private static final String SHUTTERING_BEAN = "DefaultShutteringMBean"; | ||
| private static final String CATCHUP_BEAN = "DefaultCatchupMBean"; | ||
|
|
||
| private Map<Object, ObjectName> mbeanMap = createMBeanMap(); |
There was a problem hiding this comment.
Maybe we can make this more extensible by injecting an object that contains the map of MBeans to register
Pull Request Test Coverage Report for Build 436
💛 - Coveralls |
mapingo
reviewed
Feb 15, 2019
| mbeanMap.put(DefaultCatchupMBean.class.newInstance(), new ObjectName(CATCHUP_DOMAIN_NAME, "type", CATCHUP_BEAN)); | ||
|
|
||
| return mbeanMap; | ||
| } catch (final Exception exception) { |
There was a problem hiding this comment.
Might be better to catch the actual Exceptions that are thrown rather than this catch all
MartinYSpasov
force-pushed
the
add-jmx
branch
4 times, most recently
from
f76bd6e
to
55ac6f6
Compare
mapingo
approved these changes
Feb 18, 2019
MartinYSpasov
force-pushed
the
add-jmx
branch
from
55ac6f6
to
a9a2a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.