Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI11 Fuzzing #846

Merged
merged 2 commits into from
Mar 9, 2023
Merged

CLI11 Fuzzing #846

merged 2 commits into from
Mar 9, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Feb 11, 2023

This PR adds the start of a fuzzing system for CLI11. It currently includes 1 issue fix found by fuzzing so I want to get it merged so we can continue to expand on it.

At some point I think it would worthwhile to try to get into OSS-Fuzz for CLI11 since it lies at the front end of an increasingly large number of projects given by the # of stars.

@phlptp phlptp requested a review from henryiii February 11, 2023 19:47
@phlptp
Copy link
Collaborator Author

phlptp commented Feb 12, 2023

May have opened a bit of black hole here, this could take a while to resolve.

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7a693ed) 99.45% compared to head (d36c9e9) 99.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   99.45%   99.46%           
=======================================
  Files          18       18           
  Lines        4071     4083   +12     
=======================================
+ Hits         4049     4061   +12     
  Misses         22       22           
Impacted Files Coverage Δ
include/CLI/TypeTools.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp
Copy link
Collaborator Author

phlptp commented Feb 13, 2023

I think this is ready for initial review, squashed all the commits together to a single one. The fuzz program is by no means complete but this is a start, and it already found a couple bugs. I hope to keep expanding it but I think getting it into the main branch will be good, and a place to build on. With the eventual aim to get it into OSS-Fuzz.

@henryiii
Copy link
Collaborator

Okay. The copyright lines at the top are a bit inconsistent; some of them are the original header, some are LL, and some don't have one at all.

@phlptp
Copy link
Collaborator Author

phlptp commented Feb 16, 2023

I will clean up the copyright, next time I work on this, probably sometime this weekend.

pre-commit-ci bot and others added 2 commits March 9, 2023 14:25
…e fuzzing code, a simple test, and two fixes to issues(seg faults) found by the initial round of fuzzing. It also adds a few tests and coverage issues uncovered in the process of developing the fuzz tests. As a side effect adjusts some of the azure tests to specify the vmImage which was being changed on azure.
@henryiii henryiii merged commit 0a615f8 into CLIUtils:main Mar 9, 2023
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Mar 9, 2023
@phlptp phlptp deleted the master branch March 11, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants