regular and literal strings #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 18 18
Lines 4175 4492 +317
==========================================
+ Hits 4175 4492 +317 ☔ View full report in Codecov by Sentry. |
|
@henryiii this PR handles string literals and escaped string differently including unicode escape sequences. Basically working towards more complete TOML compliance. The next one will add a few more capabilities like a transformer that can handle escaped strings and some additional documentation on the topic. This changes the way a few edge cases are handled, and fixes a few more edge cases the fuzzer caught. I will merge this on 2023-12-30 unless you have some comments or issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add escaping to quoted strings, differentiate between literal and regular strings.
The goal is to make string processing in config files as close as possible to toml standards. This means handing escape sequences including unicode, and differentiating between literal strings and regular strings in files and when splitting the command line. Also allowing variable names in the files to be quoted.
This PR gets partway there. Removes some hacks from the previous PR to deal with unusual option names and replaces with the quoted names.