Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all capabilities for toml integers and floating point numbers #968

Merged
merged 8 commits into from
Jan 2, 2024

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Dec 31, 2023

This PR add support for all TOML integer types.
This includes

{"+99", 99},
    { "99",99 },
    { "0xDEADBEEF",0xDEADBEEF },
    { "0xdeadbeef",0xDEADBEEF },
    { "0xdead_beef",0xDEADBEEF },
    { "0xdead'beef",0xDEADBEEF },
    { "0o01234567",001234567 },
    { "0o755",0755 },
    { "0755",0755 },
    { "995862_262",995862262 },
    { "995862262",995862262 },
    { "+995862275",+995862275 },
    { "995'862'275",995862275 },
    {"0b11010110",0xD6},
    {"0b1101'0110",0xD6},
    {"1_2_3_4_5",12345},

So support for separators (Toml and C++ standards), binary(new), hex(worked previously), and octal(new)

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc137f0) 100.00% compared to head (8428b19) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         4506      4555   +49     
=========================================
+ Hits          4506      4555   +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phlptp phlptp requested a review from henryiii January 1, 2024 22:25
@phlptp
Copy link
Collaborator Author

phlptp commented Jan 1, 2024

Todo in next PR, Transform operation with escaped strings so it can be done in the CLI processing, and documentation update

@phlptp phlptp merged commit 9110160 into CLIUtils:main Jan 2, 2024
50 checks passed
@phlptp phlptp deleted the toml_integer_support branch January 3, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant