Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Fix issues with ResponseDomain being linked from col on question grid… #293

Merged
merged 1 commit into from
Jul 29, 2019
Merged

WIP Fix issues with ResponseDomain being linked from col on question grid… #293

merged 1 commit into from
Jul 29, 2019

Conversation

simonreed
Copy link
Contributor

…s #82 #282

Addressses #82 and #282

Previously the response domain for a question grid was not being added/deleted correctly.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 76.196% when pulling 47c97a9 on feature/282-question-grid-response-domains into 6abc5e4 on develop.

@charlesdebarros
Copy link
Contributor

Corrections made regarding the existence of rds (response domains) and how to deal with unusual situations.
Set of tests covering the changes have been added.
Great work.

@charlesdebarros charlesdebarros merged commit 7ff77eb into develop Jul 29, 2019
charlesdebarros
charlesdebarros reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@charlesdebarros charlesdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections made regarding the existence of rds (response domains) and how to deal with unusual situations.
Set of tests covering the changes have been added.
Great work.

@spuddybike spuddybike requested review from HayleyMills and removed request for spuddybike July 31, 2019 16:20
@HayleyMills HayleyMills assigned simonreed and unassigned HayleyMills Aug 5, 2019
@simonreed
Copy link
Contributor Author

@spuddybike @charlesdebarros this is a pull request rather than an issue so how come this is in the project? Is this to say that the merge into develop which has been completed also need to go into the release branch?

@charlesdebarros charlesdebarros removed the request for review from HayleyMills August 6, 2019 09:18
@spuddybike spuddybike deleted the feature/282-question-grid-response-domains branch April 25, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesdebarros charlesdebarros charlesdebarros left review comments

Assignees

@charlesdebarros charlesdebarros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonreed @coveralls @charlesdebarros @HayleyMills