Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for "Baked-In" services to be overwritten #10

Closed
CLeeSpruit opened this issue Jan 12, 2020 · 1 comment
Closed

Allow for "Baked-In" services to be overwritten #10

CLeeSpruit opened this issue Jan 12, 2020 · 1 comment
Labels

Comments

@CLeeSpruit
Copy link
Owner

Describe current status
As of writing, Vivi has 4 baked in services, ApplicationEvent, Logger, NodeTree, and ParseEngine.
While NodeTree and ParseEngine are pretty integral to Vivi and would likely not be touched, I can see ApplicationEvent and Logger being annoying for a user that would want a custom solution as ApplicationEvent uses Zephyr for event handling over something like say RxJS and a lot of people like rolling their own logging services.

Describe the outcome you'd like
Allow for custom baked-in services to be injected into the module.

Additional context
This would assist in implementing #8 as it requires Logger to be expanded.

@CLeeSpruit CLeeSpruit added enhancement New feature or request rel: Module labels Jan 12, 2020
CLeeSpruit pushed a commit that referenced this issue Jan 12, 2020
# [5.1.0](v5.0.4...v5.1.0) (2020-01-12)

### Features

* **services:** services are injectable ([4fd8583](4fd8583)), closes [#10](#10)
@CLeeSpruit
Copy link
Owner Author

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant