Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pileup aware SimClustering #2

Closed

Conversation

lgray
Copy link

@lgray lgray commented Jul 15, 2016

As mentioned via email, this is the topic branch for simclustering.
It needs some polish before going into CMSSW proper but the major functionality is there.

After you merge it you will have to rerun any sample you have already generated from the digitization step in order to access the sim clusters.

The sim clustering is implemented by following the GEANT sim information of each event fed to the mixing module, and keeping track of the per rechit energy normalization over all events. This yields a list of DetIds and fractions that are essentially "perfect".

This list of detids and fractions is then used to make PFClusters that take the fractions and apply it to the reconstructed per-cell energy.

The SimClusters are also organized into "CaloParticles" which you can think of as the logical equivalent of SuperClusters in the modern CMSSW reconstruction, they are groups of SimClusters which represent a single stable generator particle (i.e. before GEANT propagation).

@clelange Could you give this a try?

@lgray
Copy link
Author

lgray commented Jul 17, 2016

More instructions:

You can get the sim clusters with reconstructed energy assigned through the collection:
particleFlowClusterHGCal

The original sim clusters, which have the GEANT energy assigned, are in:
mix:MergedCaloTruth and are in a collection thats of type std::vector<SimCluster>

The "reco-level" sim clusters and the "sim-level" sim clusters are indexed the same and you can perform exact matching simply using the index.

The CaloParticles are available via:
mix:MergedCaloTruth and are in a collection that's of type std::vector<CaloParticle>

@lgray
Copy link
Author

lgray commented Jul 20, 2016

@clelange Can you regenerate the samples you made previously with this last commit included?

I had a fix a bug where the SimClusters where randomly including the first RecHit in the Hit list if a given hit gathered in the SimClustering step did not make it past the reconstruction because of noise or the signal energy being too small.

@clelange
Copy link

@lgray Yes, will do.

@clelange
Copy link

Samples are done in RECO step (only pi0 still running). Ntuples should be available soon. Date tag is 20160721.

@clelange
Copy link

clelange commented Oct 6, 2016

Closing, not needed anymore.

@clelange clelange closed this Oct 6, 2016
lgray pushed a commit that referenced this pull request Oct 22, 2016
clelange pushed a commit that referenced this pull request May 17, 2017
CMSSW GCC 7.0.1 builds now follows jemalloc (dev branch) and also has a
new TCMalloc. Both of these have C++14 sized deallocation feature
enabled. This means that if possible operator delete will be called with
size argument, which will help allocator to reduce the time to free the
object. E.g. this is not possible for incomplete types which size is
unknown at a time.

GCC 7.0.1 builds contain an additional build of jemalloc
(jemalloc-debug) which contains extra asserts and checks for developers.

This seems to be undefined behavior in C++14. From [expr.delete] (5.3.5
Delete):

    In the first alternative (delete object), if the static type of the
    object to be deleted is different from its dynamic type, the static type
    shall be a base class of the dynamic type of the object to be deleted
    and the static type shall have a virtual destructor or the behavior is
    undefined.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
clelange pushed a commit that referenced this pull request May 17, 2017
clelange pushed a commit that referenced this pull request May 17, 2017
clelange pushed a commit that referenced this pull request May 17, 2017
Revert "remove customization function for redigi"
clelange pushed a commit that referenced this pull request May 17, 2017
…2-9_2_X

CTPPS: bug fix #2 in run ranges for FEDs channels mapping (9_2_X)
pfs pushed a commit that referenced this pull request May 8, 2023
pfs pushed a commit that referenced this pull request May 29, 2023
Add SC jets from extended tracks to event content.
pfs pushed a commit that referenced this pull request May 29, 2023
* added EXOLLPJetHCAL skim (initial version)

* added test script test_EXOLLPJetHCAL_SKIM.py

* Replace cout with edm::Logverbatim in Geometry/GlobalTrackingGeometryBuilder

* Re-enable unit tests for ASAN build

* dd4hep phase2 wf

* Add wf *.81 for BPH DQM

* Added utility script edmFileInPath

* improve unt test; use edmFileInPath; convert to bash

* Replace std::cout with edm::LogVerbatim in Geometry/HcalEventSetup and Geometry/HcalTestBeamData. Also add some missing files needed for testing

* Code check

* Remove FWCore TestHelper utility

* Add ap_data type for GT interface

Update GMT emulator for new ap format

Also clean up the config file

Update Z0/D0 according to GT

Using 0.05 for Z0 and 0.03 for d0.

update code format

Bug fix in tracker muon matching

Thanks to Santi for spotting this. This line was commented out by
someone, likely by accident.

Update the reference type to SA muons

* improve unit test testCreateRandomMisalignment

* Add back removed data version

* fix bug in computation of barycenters per partition and improve graphical display

* get rid of gROOT->Reset() in GeometryComparisonPlotter.cc

---------

Co-authored-by: Kiley Kennedy <kiley.elizabeth.kennedy@cern.ch>
Co-authored-by: Sunanda <sunanda.banerjee@cern.ch>
Co-authored-by: Shahzad Malik Muzaffar <shahzad.malik.muzaffar@cern.ch>
Co-authored-by: Norraphat <srimanob@mail.cern.ch>
Co-authored-by: AdrianoDee <adriano.diflorio@ba.infn.it>
Co-authored-by: Zhenbin Wu <zhenbin.wu@gmail.com>
Co-authored-by: cmsbuild <cmsbuild@cern.ch>
Co-authored-by: mmusich <marco.musich@cern.ch>
Co-authored-by: Andrew David Loeliger <andrew.loeliger@cern.ch>
pfs pushed a commit that referenced this pull request May 29, 2023
pfs pushed a commit that referenced this pull request Jun 22, 2023
Merge from cmssw master
pfs pushed a commit that referenced this pull request Mar 30, 2024
commit a7454c6
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 12 14:22:51 2024 +0100

    Updated binning for sigma(TOF) validation histograms

    Updated binning for sigma(TOF) validation histograms

    Updated binning for sigma(TOF) validation histograms

commit e0dc3be
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 16:40:42 2024 +0100

    Code checks && format (#2)

commit 7c70ed8
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 15:57:59 2024 +0100

    Removed debug ifdef condition on print to match previous implementation

commit 2e40a9f
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 15:54:41 2024 +0100

    Removed useless comments, files + fixed input file path for standalone MTD validation cfg file

commit 199ad72
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Feb 7 14:41:57 2024 +0100

    Code checks && code format

commit 6ec3c46
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Tue Feb 6 09:56:49 2024 +0100

    Changed SigmaTof fill location in validation

commit 6a0525e
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 5 18:11:27 2024 +0100

    Change input file to validation

commit cb7db5b
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 5 18:07:19 2024 +0100

    Saving sigmaTOF in ps

commit 00230ac
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 5 15:32:11 2024 +0100

    Removed useless prints + created member vector in TrackSegments to allocate memory for sigmaTof once

commit fdd6e31
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Tue Jan 9 16:08:46 2024 +0100

    Added sigma(p) to TrackSegments; added sigma(TOF) computation, now saved to event

commit 7d488e0
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Wed Dec 6 14:24:26 2023 +0100

    testing files

commit 88f9847
Author: noepalm <palmeri.1871005@studenti.uniroma1.it>
Date:   Mon Feb 12 12:42:15 2024 +0100

    Replaced isnan, isinf with edm::isNotFinite in MTD vertex validation
pfs pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants