94 x #44
Merged
94 x #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't the problem remain that if one hadron doesn't have a daughter it will be reset to -0.1 (and then stays there)? |
|
The else if (genDecay_ < 0) should prevent that. Because if the prevous hadron had a daughter genDecay_ will be > 0 |
|
Makes sense, but then the 'break' statement should be removed: |
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the calculation of the genDecay_ parameter the Bhadron was matched to a jet via deltaR matching, which is incorrect. Instead it should be checked whether the Bhadron is within the jet cluster.
I also fixed a potential issue that could cause the Bhadron_daughter_ array to be smaller than the Bhadron_ array resulting in a segmentation fault.