[WNMGDS-830] Update icon for success alert #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line47
commented
Mar 31, 2021
| - `$alert-padding` - Used to provide padding for the alert element | ||
| - `$alert-bar-size` - Used to control the width of the left bar on the alert | ||
| - `$alert-icon-size` - Used to control the size of the alert icon | ||
|
|
There was a problem hiding this comment.
Added the existing variables to the documentation that were not there to help with folks who want to style the alerts
line47
commented
Mar 31, 2021
| $alert-padding: $spacer-2; | ||
| $alert-bar-size: $spacer-1; | ||
| $alert-icon-size: $spacer-5; | ||
|
|
There was a problem hiding this comment.
moved variables to the top of the document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the icon used for the success alert to be more consistent with the the icons being used
Added
Changed
How to test
View the alert page and see that the success alert is using the filled check icon and matches the style of the others
You'll need to run the site locally because icons don't show on the demo URLs