-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
… hover and active) (#16) * ensure consist button styles in various states * Remove unnecessary scss block and add comments * Move landing page button styles outside of primary btn Co-authored-by: bernardwang <bw.vbnm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting the following warning message during yarn build
:
[15:14:49] 🖊 Overriding components.button.react page with docs/src/pages/components/Button/Button.docs.scss [15:15:36] WARNING in ./docs/src/pages/components/HHSLogo/HHSlogo.example.tsx 4:36-43 "export 'HHSlogo' was not found in '@design-system' [15:15:36] WARNING in ./docs/src/pages/components/CloseSymbol/CloseSymbol.example.tsx 4:36-47 "export 'CloseSymbol' was not found in '@design-system' [15:15:36] WARNING in ./docs/src/pages/components/HamburgerSymbol/HamburgerSymbol.example.tsx 4:36-51 "export 'HamburgerSymbol' was not found in '@design-system' [15:15:44] 📝 170 Example pages added to ./docs
I think it's related to the warning message mentioned above where these components are not getting exported - these react components are not working on the Mgov docs site - |
Aside from the above comment, coverage tools frontend seems to work as expected. |
@babsmiles - This PR updates CMSDS to v2.5.0 which includes changes to buttons styling to keep existing style. Can you review to ensure styling is still maintained. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Summary
button.overrides.scss
was necessary to preserve the existing styles.@design-system
aliasThe CMSDS scripts have been updated to use the
@design-system
alias over@src
. This means imports using@design-system
will resolve fromdist/esnext/index.js
, meaning you can use named imports without specifying the path. This also means example react files don't need to import from the core CMSDS package.How to test