Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

[NO_TICKET] Update CMSDS to v2.5.0 #18

Merged
merged 8 commits into from
Apr 20, 2021
Merged

Conversation

bernardwang
Copy link
Collaborator

@bernardwang bernardwang commented Mar 3, 2021

Summary

  • Update button styles to maintain existing styles
    • The CMSDS button styles had to be changed to match focus styles with hover styles. However, in the MDS focus styles are entirely independent from hover styles. Changes to button.overrides.scss was necessary to preserve the existing styles.
  • Update React example files to use @design-system alias
    The CMSDS scripts have been updated to use the @design-system alias over @src. This means imports using @design-system will resolve from dist/esnext/index.js, meaning you can use named imports without specifying the path. This also means example react files don't need to import from the core CMSDS package.

How to test

  • Ensure all MDS react examples are working as expected
  • Ensure button styles look good
  • Run this branch through coverage-tools and ensure no regressions

@bernardwang bernardwang changed the title [NO_TICKET] Update react example files to use the @design-system alias [NO_TICKET] Update to v2.4.1 of the CMSDS Mar 4, 2021
… hover and active) (#16)

* ensure consist button styles in various states

* Remove unnecessary scss block and add comments

* Move landing page button styles outside of primary btn

Co-authored-by: bernardwang <bw.vbnm@gmail.com>
@bernardwang bernardwang changed the title [NO_TICKET] Update to v2.4.1 of the CMSDS [NO_TICKET] Update CMSDS to v2.4.1 Mar 4, 2021
@bernardwang bernardwang changed the title [NO_TICKET] Update CMSDS to v2.4.1 [NO_TICKET] Update CMSDS to v2.4.2 Mar 10, 2021
@bernardwang bernardwang requested a review from nichia March 11, 2021 18:36
Copy link
Collaborator

@nichia nichia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following warning message during yarn build:
[15:14:49] 🖊 Overriding components.button.react page with docs/src/pages/components/Button/Button.docs.scss [15:15:36] WARNING in ./docs/src/pages/components/HHSLogo/HHSlogo.example.tsx 4:36-43 "export 'HHSlogo' was not found in '@design-system' [15:15:36] WARNING in ./docs/src/pages/components/CloseSymbol/CloseSymbol.example.tsx 4:36-47 "export 'CloseSymbol' was not found in '@design-system' [15:15:36] WARNING in ./docs/src/pages/components/HamburgerSymbol/HamburgerSymbol.example.tsx 4:36-51 "export 'HamburgerSymbol' was not found in '@design-system' [15:15:44] 📝 170 Example pages added to ./docs

@nichia
Copy link
Collaborator

nichia commented Mar 11, 2021

I think it's related to the warning message mentioned above where these components are not getting exported - these react components are not working on the Mgov docs site - Close Icon, HHSlogo, Hamburger Icon

@nichia
Copy link
Collaborator

nichia commented Mar 11, 2021

Aside from the above comment, coverage tools frontend seems to work as expected.

@nichia nichia requested review from kimieann and line47 April 15, 2021 13:57
@nichia nichia changed the title [NO_TICKET] Update CMSDS to v2.4.2 [NO_TICKET] Update CMSDS to v2.5.0 Apr 15, 2021
@nichia nichia requested a review from babsdenney April 15, 2021 14:04
@nichia
Copy link
Collaborator

nichia commented Apr 15, 2021

@babsmiles - This PR updates CMSDS to v2.5.0 which includes changes to buttons styling to keep existing style. Can you review to ensure styling is still maintained. Thanks

@line47 line47 requested a review from bkerstan April 15, 2021 15:34
Copy link
Contributor

@line47 line47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@nichia nichia merged commit ee1719c into master Apr 20, 2021
@nichia nichia deleted the bernard/update-cmsds-2.4.1 branch April 20, 2021 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants