Add remaining IBM Debater CSV datasets #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djalova
force-pushed
the
ibm-debater-csv
branch
from
f1ad37c
to
cb99f94
Compare
|
Is this ready for review? |
|
@xuhdev Yep this is ready |
xuhdev
reviewed
Dec 9, 2020
datasets.yaml
Outdated
| name: Unigrams Sentiment Lexicon | ||
| description: Unigrams with their sentiment score | ||
| format: | ||
| id: txt |
There was a problem hiding this comment.
Is this actually csv? txt doesn't get the column options
There was a problem hiding this comment.
It's technically a txt file but it can be read as a csv with a ' ' as the separator. Should I just change the format to csv?
There was a problem hiding this comment.
Gotcha. How about we merge this after we have addressed CODAIT/pardata#48 ?
There was a problem hiding this comment.
Alternatively, if we are to merge now, could you add a comment line:
# TODO: Replace txt with csv when PyDAX supports specifying CSV delimiters.
There was a problem hiding this comment.
Sure we can wait until that feature is implemented.
|
Conflict again... |
|
Updated with master |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds schemas for the following IBM Debater Datasets:
IBM Debater® Sentiment Compositions Lexicon