-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining IBM Debater CSV datasets #5
Conversation
f1ad37c
to
cb99f94
Compare
Is this ready for review? |
@xuhdev Yep this is ready |
datasets.yaml
Outdated
name: Unigrams Sentiment Lexicon | ||
description: Unigrams with their sentiment score | ||
format: | ||
id: txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually csv? txt doesn't get the column options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's technically a txt file but it can be read as a csv with a ' '
as the separator. Should I just change the format to csv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. How about we merge this after we have addressed CODAIT/pardata#48 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, if we are to merge now, could you add a comment line:
# TODO: Replace txt with csv when PyDAX supports specifying CSV delimiters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can wait until that feature is implemented.
Conflict again... |
Updated with master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds schemas for the following IBM Debater Datasets:
IBM Debater® Sentiment Compositions Lexicon