Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backend/view available rooms #59

Merged
merged 6 commits into from
Jun 16, 2024

Conversation

Rethakgetse-Manaka
Copy link
Contributor

@Rethakgetse-Manaka Rethakgetse-Manaka commented Jun 16, 2024

Description

I implemented a function which allows the frontend to call it and it will return 10 results of available rooms to book. A change was made to prior functions converting them from gets to post request functions.

Fixes # (issue)

Type of change

-Book-room, check-in, cancel booking were all converted to post request handlers.
Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit testing needs to be implemented for the functions

  • Unit testing implementation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (9127814) to head (21a37fd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #59   +/-   ##
========================================
  Coverage    72.88%   72.88%           
========================================
  Files            3        3           
  Lines          118      118           
========================================
  Hits            86       86           
  Misses          29       29           
  Partials         3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rethakgetse-Manaka Rethakgetse-Manaka marked this pull request as ready for review June 16, 2024 08:17
@Rethakgetse-Manaka Rethakgetse-Manaka merged commit 92d2909 into develop Jun 16, 2024
6 checks passed
@Rethakgetse-Manaka Rethakgetse-Manaka deleted the feat/backend/View-available-rooms branch June 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant