-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abort_ice does not pass an error code to MPI_abort #8
Comments
Any objections to this being merged? @nicjhan @aekiss @marshallward |
looks OK to me. |
BTW how was this even able to build with two arguments? Isn't |
Yes it is and I don't know |
As you can imagine @marshallward, this was rather confusing to |
It compiles because it includes mpif.h rather than using the mpi module.
…________________________________
From: Aidan Heerdegen <notifications@github.com>
Sent: Friday, 2 March 2018 2:26 PM
To: OceansAus/cice5
Cc: Subscribed
Subject: Re: [OceansAus/cice5] abort_ice does not pass an error code to MPI_abort (#8)
As you can imagine @marshallward<https://github.com/marshallward>, this was rather confusing to payu. I have a related issue over on the oasis repo
COSIMA/oasis3-mct#2<COSIMA/oasis3-mct#2>
-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMHgB-mVxIkqQlVeHAXHZsmPtKaaGnDcks5taLv_gaJpZM4SZUBH>.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the same issue Martin Dix discovered:
https://accessdev.nci.org.au/trac/ticket/318
The call signature for
MPI_Abort
ishttps://www.open-mpi.org/doc/v1.10/man3/MPI_Abort.3.php
It is called here:
https://github.com/OceansAus/cice5/blob/master/mpi/ice_exit.F90#L61
but the value of
ierr
is not set in the routine, so it is whatever it was initialised to by the compiler.They had a similar issue with oasis_abort:
https://portal.enes.org/oasis/faq-forum/oasis3-forum/real-coupled-models/548853210
Apparently they decided oasis_abort should default to a non-zero value, it is an abort call after all.
The text was updated successfully, but these errors were encountered: