-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide namelist option surf_vel_scale in surface_flux_nml to use abso… #30
Conversation
…lute (rather than relative) wind for all surface fluxes. COSIMA/access-om2#137
@aekiss No, the namelist variable is private to the surface_flux module. I wouldn't think it would compile. I think it would be better to make the change here Just make an if block to calculate udif as either the difference or |
Ah yes that was dumb, I was wondering about the scope of the namelist variable. I'd initially suggested we modify those lines in surface_flux_mod.F90 (445 to 446 in 6f8f1ed, 440-441 in master) but you suggested we set the surface velocities to zero in the atmospheric flux calculation instead |
Oops, I'll have to delete that comment from the record! Actually, I think it's much better, in the MOM/CICE setup, to supply the correct surface velocities to the surface_flux module and let it decide what it wants to do with them. The same with CICE. If it wants the ocean velocity then it can choose whether to use it or not. MOM/SIS is a bit different since it uses the |
Don't worry, it will disappear from Slack soon enough... unlike my bad coding here. |
Looks good to me. Having a quick test run (or at least compile) example would be nice. One for the TWG... |
This didn't compile (can't have an IF inside a WHERE) so to avoid the IF I've reimplemented it in terms of a surface velocity scaling factor |
I should have spotted that. You need to break the WHERE construct apart and have two branches. I think a clearer approach would be to to use the logical but set the value of |
OK how's this? It compiles happily. |
Looks good. Yeah, I think the documentation for |
Yes, that's what I thought. |
I've completed test runs - it seems fine. |
…lute (rather than relative) wind for all surface fluxes. COSIMA/access-om2#137
@russfiedler, @nichannah does this look like it will work? I haven't checked that it will compile...