Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wombat #47

Merged
merged 9 commits into from
Jun 7, 2020
Merged

Wombat #47

merged 9 commits into from
Jun 7, 2020

Conversation

russfiedler
Copy link
Contributor

Added 10m wind forcing for use with WOMBAT (ACCESS-OM-BGC) and enable enhanced langmuir mixing in OM2

@aekiss
Copy link
Contributor

aekiss commented Jun 4, 2020

@aidanheerdegen, @nichannah just wondering if you're happy with this PR

@aidanheerdegen
Copy link
Contributor

Haven't look TBH. Will take a gander, though not sure I have any useful domain/code knowledge.

@aekiss
Copy link
Contributor

aekiss commented Jun 4, 2020

great, thanks @aidanheerdegen. @nichannah if you could look this over too that would be good.

@aidanheerdegen
Copy link
Contributor

Seems ok to me.

@aekiss aekiss merged commit 26e6159 into COSIMA:master Jun 7, 2020
@aekiss
Copy link
Contributor

aekiss commented Jun 7, 2020

Merged - @nichannah was also happy with it, but curious about what the change in drivers/auscom/cpl_netcdf_setup.F90 does - @russfiedler can you elucidate?

@russfiedler
Copy link
Contributor Author

@aekiss Good point, I'm not sure who first introduced that piece of code nor why it was dropped. I remember seeing it somewhere and added it. It might be in the ACCESS-CM code. Anyway, what it does is provide space in the header of the file for adding new variables and attributes and aligns data. TBH I think a better call would be to name the arguments to make things clearer

call ncheck(nf__enddef(ncid,h_minfree=1028,v_align=512,v_minfree=512,r_align=512), 'create_ncfile: nf__enddef')

The h_minfree option seems pretty necessary as there looks to be quite a few additions of variables along with writing fields. This should avoid copying the file unnecessarily. I use it quite a bit. I'm not sure on the performance gains/hits with the other options.

@aekiss
Copy link
Contributor

aekiss commented Jun 9, 2020

ok thanks Russ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants