Add support for providing relative humidity rather than specific humidity as an input file #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
update cice
|
I think it might be a good idea to use some predefined constants (from ice_constants.F90, say) rather than the magic numbers. 100.0 => c11 and define d622 = rdgas/rvgas Also add a quick reference for the formula. |
|
How's this? I'll test it again before it should be merged. |
|
Looks good. Happy to merge if your tests look ok. |
|
Ok the tests check-out, giving an identical figure to that shown at #57 (comment) I think it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach uses a simpler formula for converting RH to QH than used by the model internals. This should not be an issue provided the same formula is used for the pre-processing when the JRA55-do provided QH is converted to RH.