Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ERA-5 fliplat command and assert checks in base_grid.py to sup… #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmholmes
Copy link

…port latitude reverse ordering in ERA-5.

Should I do something better than just removing the checks?

@micaeljtoliveira
Copy link
Contributor

@aekiss You probably know what this is about, as you actively participated in the discussion of #4. Should we merge this as is?

@anton-seaice
Copy link
Contributor

I think we should move the assert statements to a test, and test based on the grid type.

I.e. for most grids. " # The bottom latitude band should always be Southern extent." is a true statement but for ERA5, the opposite is true.

Saying that, many grids don't need these corner points, so the code is not actually relevant for ERA5 grids? I don't understand enough about the remapping in OM2 to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants