Refactor Current Trip signals #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
commented
Nov 18, 2022
| @@ -184,16 +184,43 @@ Speed: | |||
| description: Vehicle speed. | |||
|
|
|||
| TravelledDistance: | |||
| deprecation: V3.1 moved to Vehicle.TraveledDistance | |||
There was a problem hiding this comment.
Today we are mixing British and American English. While poking around in this area, do we think it is a good idea to rename TravelledDistance to TraveledDistance (using our deprecated-methodology, i.e. keeping old signal until v4.0)
erikbosch
commented
Nov 18, 2022
spec/Vehicle/Vehicle.vspec
Outdated
| A trip is considered to end when engine is no longer enabled. | ||
| The signal may however keep the value of the last trip until a new trip is started. | ||
|
|
||
| TimeSinceStart: |
There was a problem hiding this comment.
Proposing to move this signal from FuelSystem to Vehicle as it might be relevant for any vehicle
There was a problem hiding this comment.
Meeting notes:
Daniel: Would it be better to have starttime than time since start?
Ulf: Dont we not need a signal for "now" as well
Daniel: Assume apps can always get current time
Erik: Have no problems having start time instead
erikbosch
commented
Nov 18, 2022
| A trip is considered to end when engine is no longer enabled. | ||
| The signal may however keep the value of the last trip until a new trip is started. | ||
|
|
||
| TripMeterReading: |
There was a problem hiding this comment.
For traveled distance I see it relevant to have 3 values
- TraveledDistance - the value for the life time of the vehicle
- TraveledDistanceSinceStart - the value since start of current trip
- TripMeterReading - the value since manual reset (by driver)
Adapting description accordingly.
erikbosch
commented
Nov 18, 2022
| @@ -214,7 +241,10 @@ AverageSpeed: | |||
| type: sensor | |||
| unit: km/h | |||
| description: Average speed for the current trip. | |||
|
|
|||
| comment: A new trip is considered to start when engine gets enabled (e.g. LowVoltageSystemState in ON or START mode). | |||
There was a problem hiding this comment.
Is it sufficient to have a single AverageSpeed - is so do we want to keep old name, or rename to AverageSpeedSinceStart to be better aligned with other signals referring to current trip.
Or do we need additional signals for average speed - e.g. by adding one related to average speed over lifetime or average speed since trip meter reset?
erikbosch
commented
Nov 18, 2022
| @@ -76,8 +76,12 @@ ConsumptionSinceStart: | |||
| type: sensor | |||
| unit: l | |||
| description: Fuel amount in liters consumed since start of current trip. | |||
| comment: A new trip is considered to start when engine gets enabled (e.g. LowVoltageSystemState in ON or START mode). | |||
There was a problem hiding this comment.
Is it sufficient to have consumption since start of current trip, or do we also need a signal for "consumption since trip meter reset". Similar for the signal AverageConsumption above. Today we state that period is a variation point, shall we better specify that it is for current trip or split it to two signals, one for "average consumption for current trip" and one for "average consumption since trip meter reset"
|
In case we want to agree that - if in doubt - American English spelling "wins", should we write it down somewhere in the docs? |
Briefly mentioned in https://github.com/COVESA/vehicle_signal_specification/blob/master/CONTRIBUTING.md#use-existing-style |
|
Meeting notes:
|
erikbosch
force-pushed
the
erikbosch/erik_current_trip
branch
2 times, most recently
from
538a036
to
1a71a72
Compare
erikbosch
commented
Dec 15, 2022
| A trip is considered to end when engine is no longer enabled. | ||
| The signal may however keep the value of the last trip until a new trip is started. | ||
|
|
||
| StartTime: |
There was a problem hiding this comment.
Changed from TimeSinceStart to StartTime based on discussion in last meeting.
Using string in UTC-format, as that is the format used in some other places in the tree to represent time - we currently do not use unix time stamps (i.e. seconds since 1970 represented as an int value anywhere)
(That is a side topic that comes up now and then, do we in VSS syntax need something that from a formal perspective tells that a signal contains a time stamp, either by using a predefined unit, or a datatype alias (for example "datatype:time" but specifying that it means string + iso 8601 syntax)
|
Decision postponed to give time for more comments. Topics discussed at meeting:
|
|
A thought - if we change to |
erikbosch
force-pushed
the
erikbosch/erik_current_trip
branch
from
1a71a72
to
8591c10
Compare
erikbosch
force-pushed
the
erikbosch/erik_current_trip
branch
from
8591c10
to
0b8920d
Compare
erikbosch
commented
Jan 10, 2023
|
|
||
| EndTime: | ||
| datatype: string | ||
| type: sensor |
There was a problem hiding this comment.
Meeting notes:
- Daniel: Is rather an attribute, change only once per ignition cycle.
- Sebastian: but could be not that intuitative to subscribe to an attribute to be informed when trip finishes.
- Daniel: Can be better to have both start time (attribute) and duration (sensor).
- Decision: Erik to adapt to PR to use "both start time (attribute) and duration (sensor)". After update, others shall review. Merge or continued discussion on next meeting
erikbosch
commented
Jan 12, 2023
| StartTime: | ||
| datatype: string | ||
| type: attribute | ||
| default: '0000-01-01T00:00Z' |
There was a problem hiding this comment.
At last meeting we discussed a bit on what an attribute is, and if this signal makes sense to be an attribute as it is only set once per ignition cycle. I changed the PR to use attribute as type, but then I found that we say in documentation that an attribute must have a default value. Although not explicitly said I assume it originates from an idea that an attribute always will have a value, i.e. if you do a Read you will always get a value (if the signal is defined), compared to sensors where you might get an answer that no value is available.
We can discuss if we want to keep this restriction for attributes - for now selecting a year 0 as default value, if used indicating that vehicle has never been started or that latest start time is unknown
|
Meeting decision: merge |
jdacoello
pushed a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
Feb 15, 2023
* Refactor Current Trip signals * Refactoring based on review comments
jdacoello
added a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
Feb 15, 2023
This reverts commit 503ef90.
jdacoello
added a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
Feb 15, 2023
* Revert "Minor editorial change" This reverts commit 13a3231. * Revert "Add Power Optimize concept" This reverts commit 750c4fa. * Revert "Add steering angle" This reverts commit cfbcaff. * Revert "Use explicit VSS units" This reverts commit 64cbe3a. * Revert "Refactor Current Trip signals (COVESA#509)" This reverts commit 503ef90. * Revert "Update _index.md" This reverts commit 2431461. * Revert "Add light switches" This reverts commit f19285d. * Revert "Fix quotes for TirePressureUnit" This reverts commit fce40fe. * Revert "Add HMI signals (COVESA#512)" This reverts commit 9680e49. * Revert "Add SmartphoneMirroring into HMI branch (COVESA#500)" This reverts commit b383c7d. * Revert "Add volume property to Navigation branch (COVESA#504)" This reverts commit 141b6ad. * Revert "reivsed with all uppper case string" This reverts commit 834753b. * Revert "Add mute of navigation branch" This reverts commit ff3ad34. * Revert "Add PlaybackSpeed into Media.Played (COVESA#499)" This reverts commit 65cf0be. * Revert "Add tire pressure unit to HMI (COVESA#501)" This reverts commit d198cc2. * Revert "Extend governance and changelog information" This reverts commit 027efa8. * Revert "Adapt overlay documentation to implicit branches" This reverts commit fcb9c5c. * Revert "Enable proper search in generated documentation" This reverts commit 3d0da59. * Revert "Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494)" This reverts commit 73b8e27. * Revert "Update vss-tools to latest version (COVESA#492)" This reverts commit 871503c. * Revert "Extend motorbike profile and include profiles in builds (COVESA#487)" This reverts commit 3d66406. * Revert "Remove pipenv parameter sequential (COVESA#496)" This reverts commit 47c72cd. * Revert "Improve seat tilt documentation" This reverts commit dc92ba7. * Revert "Remove obsolete sensor/actuator properties" This reverts commit 1cb3245. * Revert "Improve trunk/hood documentation (COVESA#480)" This reverts commit 354b43b. * Revert "Add low voltage battery signals" This reverts commit 0a2786c. * Revert "Buildcheck update" This reverts commit d76de94. * Revert "changed from HasDefect to IsDefect in all new files" This reverts commit 4d874c8. * Revert "Added changes from comment of erikbosch" This reverts commit ca7b84e. * Revert "deleted istances for brake and licence-plates" This reverts commit 1f1a67a. * Revert "header updated" This reverts commit a10785e. * Revert "Naming changes due to feedback" This reverts commit 50ba98f. * Revert "Changed Break to Brake and fixed wrong filenames." This reverts commit 3103ea3. * Revert "Added lights for license-plate and break-lights" This reverts commit 6a6a17a. * Revert "Feedback integrated: Comments end with '.' and file are renamed" This reverts commit 6a38da8. * Revert "Reduced number of files" This reverts commit b20f522. * Revert "added files for different types of exterior lights" This reverts commit ee184b4. * Revert "added further structuring of lights." This reverts commit 1aacf35. * Revert "Added a flag to indicate defects" This reverts commit 9c14649. * Revert "Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added" This reverts commit a3798e6. * Revert "Added vector files of logo" This reverts commit f8f1820. * Revert "Include graphql fix" This reverts commit e02d8d3. * Revert "Update dds tool" This reverts commit 7a51868. * Revert "Fix link to checklist (COVESA#474)" This reverts commit 162e893. * Revert "Update version to 3.1-develop (COVESA#472)" This reverts commit 278c0ee. * Revert "Prepare master branch for 3.0 release (COVESA#471)" This reverts commit 2e03275. * Revert "Add tar-file command to Makefile (COVESA#469)" This reverts commit a84b536. * Revert "Updated logo and color theme (COVESA#470)" This reverts commit db6f32b. * Revert "Documentation of new keyword `instantiate` (COVESA#461)" This reverts commit dc35859. * Revert "feat: Add data point Wheel.Speed" This reverts commit 93119b0. * Revert "Removed private and fixed typos" This reverts commit 4c9cef3. * Revert "Overlay documentation" This reverts commit 14dc4e4. * Revert "Remove obsolete files" This reverts commit da4eb08.
jdacoello
added a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
Feb 21, 2023
Remove obsolete files The release management picture is outdated and not used The structure.txt file does not provide much value Overlay documentation The documentation summarises idea and useage of overlays, as implemented in COVESA/vss-tools#173 Detailed documentation of the CLI will be done in tools. This just serves as an overview and background. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Removed private and fixed typos - removed private branch, as it's now handled by overlays - fixed typos. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> feat: Add data point Wheel.Speed Documentation of new keyword `instantiate` (COVESA#461) As discussed in COVESA#448 and implemented in COVESA/vss-tools#168 it gives more flexibility in defining instances. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Updated logo and color theme (COVESA#470) * added the new logo * updated color theme to blue Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Add tar-file command to Makefile (COVESA#469) Also remove obsolete deploy command and update gitignore Prepare master branch for 3.0 release (COVESA#471) Update version to 3.1-develop (COVESA#472) Fix link to checklist (COVESA#474) Update dds tool Include graphql fix Added vector files of logo Fixes: COVESA#451 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added Added a flag to indicate defects added further structuring of lights. added files for different types of exterior lights Reduced number of files Feedback integrated: Comments end with '.' and file are renamed Added lights for license-plate and break-lights Changed Break to Brake and fixed wrong filenames. Naming changes due to feedback header updated deleted istances for brake and licence-plates Added changes from comment of erikbosch changed from HasDefect to IsDefect in all new files Buildcheck update Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add low voltage battery signals Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Improve trunk/hood documentation (COVESA#480) Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Remove obsolete sensor/actuator properties They have never been used and are not supported in tools. Better to reintroduce them if/when we in VSS specifies recommended additional properties for e.g. security purposes or protocol adoptions. Also improving documentation based on PR review. Fixes COVESA#302 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Improve seat tilt documentation A small error was detected - when tilt is 0 seat is not parallel to X-axis, it is rather seating (seat bottom) that is parallel to Z-axis. Also minor rephrasing. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Remove pipenv parameter sequential (COVESA#496) This parameter was added to solve buildproblems some time ago. But now it has been removed and thus must be removed from our code as well Changed in pipenv v2022.9.20 pypa/pipenv@a38d153 Extend motorbike profile and include profiles in builds (COVESA#487) This PR contains some signals relevant to motorbikes. Some of them might be of general interest and may be moved to "standard vss" later. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Update vss-tools to latest version (COVESA#492) Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494) Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Enable proper search in generated documentation Previously we did not generate the JSON index required. Also bumping hugo version. Local test succesfull. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Adapt overlay documentation to implicit branches Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Extend governance and changelog information Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add tire pressure unit to HMI (COVESA#501) * Add tire pressure unit to HMI - It needs to add tire pressure unit to HMI branch because there are three different units related with tire pressure in usual. * Fix syntax error - add ':' into the end of "HMI.TirePressureUnit" * Replace allowed value strings with upper case - Replace allowed value strings with upper case Add PlaybackSpeed into Media.Played (COVESA#499) * Add PlaybackSpeed into Media.Played - It needs to add Playback Speed into Media.Played branch because it's important feature to change playback speed on some media services as audio book, youtube video * the restrictions of PlaybackSpeed the restrictions of PlaybackSpeed * Additional descriptions for meaning of the values Add text below for better understanding. comment: 1 means normal speed. <1 means slower playback than normal. >1 means faster playback than normal. * Revised with the meeting result - Aligned work with https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/playbackRate Add mute of navigation branch It is required to add date property for navigation mute. reivsed with all uppper case string Add volume property to Navigation branch (COVESA#504) * Add volume property to Navigation branch It need to have a volume property of Navigation to control the navigation guidance volume. * add unit: percent - Added unit: percent to Navigation.Volume and Media.Volume Add SmartphoneMirroring into HMI branch (COVESA#500) * Add SmartphoneMirroring into HMI branch It is required to support SmartphoneMirroring into HMI branch. Mirroring service such as AndroidAuto, AppleCarplay, and MirrorLink are broadly used in recent HMI system in the vehicle. The connectivity information for smart device such as android or iOS based phone or tablet is required for VSS. * Resolving the syntax error * Update for resolving comments * Update of naming and allowed values for projection * Reflect the comments from Erik Add HMI signals (COVESA#512) Adds two HMI-related signals existing in Android HAL but not existing in VSS FUEL_VOLUME_DISPLAY_UNITS DISPLAY_BRIGHTNESS Fix quotes for TirePressureUnit Add light switches VSS as of today has individual signals controlling/reporting if lights are on, but it does not have any signals representing the controls typically available to the driver. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Update _index.md Fixed format error in Governance page. Refactor Current Trip signals (COVESA#509) * Refactor Current Trip signals * Refactoring based on review comments Use explicit VSS units Add steering angle This adds steering angle for road wheels. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add Power Optimize concept This is a power optimization concept based on discussions in the COVESA power optimization project Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Minor editorial change Replaces COVESA#529 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Revert "Update by pulling changes from COVESA VSS master" (#2) * Revert "Minor editorial change" This reverts commit 13a3231. * Revert "Add Power Optimize concept" This reverts commit 750c4fa. * Revert "Add steering angle" This reverts commit cfbcaff. * Revert "Use explicit VSS units" This reverts commit 64cbe3a. * Revert "Refactor Current Trip signals (COVESA#509)" This reverts commit 503ef90. * Revert "Update _index.md" This reverts commit 2431461. * Revert "Add light switches" This reverts commit f19285d. * Revert "Fix quotes for TirePressureUnit" This reverts commit fce40fe. * Revert "Add HMI signals (COVESA#512)" This reverts commit 9680e49. * Revert "Add SmartphoneMirroring into HMI branch (COVESA#500)" This reverts commit b383c7d. * Revert "Add volume property to Navigation branch (COVESA#504)" This reverts commit 141b6ad. * Revert "reivsed with all uppper case string" This reverts commit 834753b. * Revert "Add mute of navigation branch" This reverts commit ff3ad34. * Revert "Add PlaybackSpeed into Media.Played (COVESA#499)" This reverts commit 65cf0be. * Revert "Add tire pressure unit to HMI (COVESA#501)" This reverts commit d198cc2. * Revert "Extend governance and changelog information" This reverts commit 027efa8. * Revert "Adapt overlay documentation to implicit branches" This reverts commit fcb9c5c. * Revert "Enable proper search in generated documentation" This reverts commit 3d0da59. * Revert "Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494)" This reverts commit 73b8e27. * Revert "Update vss-tools to latest version (COVESA#492)" This reverts commit 871503c. * Revert "Extend motorbike profile and include profiles in builds (COVESA#487)" This reverts commit 3d66406. * Revert "Remove pipenv parameter sequential (COVESA#496)" This reverts commit 47c72cd. * Revert "Improve seat tilt documentation" This reverts commit dc92ba7. * Revert "Remove obsolete sensor/actuator properties" This reverts commit 1cb3245. * Revert "Improve trunk/hood documentation (COVESA#480)" This reverts commit 354b43b. * Revert "Add low voltage battery signals" This reverts commit 0a2786c. * Revert "Buildcheck update" This reverts commit d76de94. * Revert "changed from HasDefect to IsDefect in all new files" This reverts commit 4d874c8. * Revert "Added changes from comment of erikbosch" This reverts commit ca7b84e. * Revert "deleted istances for brake and licence-plates" This reverts commit 1f1a67a. * Revert "header updated" This reverts commit a10785e. * Revert "Naming changes due to feedback" This reverts commit 50ba98f. * Revert "Changed Break to Brake and fixed wrong filenames." This reverts commit 3103ea3. * Revert "Added lights for license-plate and break-lights" This reverts commit 6a6a17a. * Revert "Feedback integrated: Comments end with '.' and file are renamed" This reverts commit 6a38da8. * Revert "Reduced number of files" This reverts commit b20f522. * Revert "added files for different types of exterior lights" This reverts commit ee184b4. * Revert "added further structuring of lights." This reverts commit 1aacf35. * Revert "Added a flag to indicate defects" This reverts commit 9c14649. * Revert "Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added" This reverts commit a3798e6. * Revert "Added vector files of logo" This reverts commit f8f1820. * Revert "Include graphql fix" This reverts commit e02d8d3. * Revert "Update dds tool" This reverts commit 7a51868. * Revert "Fix link to checklist (COVESA#474)" This reverts commit 162e893. * Revert "Update version to 3.1-develop (COVESA#472)" This reverts commit 278c0ee. * Revert "Prepare master branch for 3.0 release (COVESA#471)" This reverts commit 2e03275. * Revert "Add tar-file command to Makefile (COVESA#469)" This reverts commit a84b536. * Revert "Updated logo and color theme (COVESA#470)" This reverts commit db6f32b. * Revert "Documentation of new keyword `instantiate` (COVESA#461)" This reverts commit dc35859. * Revert "feat: Add data point Wheel.Speed" This reverts commit 93119b0. * Revert "Removed private and fixed typos" This reverts commit 4c9cef3. * Revert "Overlay documentation" This reverts commit 14dc4e4. * Revert "Remove obsolete files" This reverts commit da4eb08.
jdacoello
added a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
Feb 21, 2023
Add generic configurable light spec fix: Correct path feat: Add interactive light bar fix: Change Lights for Light (Singular) Remove obsolete files The release management picture is outdated and not used The structure.txt file does not provide much value Overlay documentation The documentation summarises idea and useage of overlays, as implemented in COVESA/vss-tools#173 Detailed documentation of the CLI will be done in tools. This just serves as an overview and background. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Removed private and fixed typos - removed private branch, as it's now handled by overlays - fixed typos. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> feat: Add data point Wheel.Speed Documentation of new keyword `instantiate` (COVESA#461) As discussed in COVESA#448 and implemented in COVESA/vss-tools#168 it gives more flexibility in defining instances. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Updated logo and color theme (COVESA#470) * added the new logo * updated color theme to blue Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Add tar-file command to Makefile (COVESA#469) Also remove obsolete deploy command and update gitignore Prepare master branch for 3.0 release (COVESA#471) Update version to 3.1-develop (COVESA#472) Fix link to checklist (COVESA#474) Update dds tool Include graphql fix Added vector files of logo Fixes: COVESA#451 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added Added a flag to indicate defects added further structuring of lights. added files for different types of exterior lights Reduced number of files Feedback integrated: Comments end with '.' and file are renamed Added lights for license-plate and break-lights Changed Break to Brake and fixed wrong filenames. Naming changes due to feedback header updated deleted istances for brake and licence-plates Added changes from comment of erikbosch changed from HasDefect to IsDefect in all new files Buildcheck update Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add low voltage battery signals Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Improve trunk/hood documentation (COVESA#480) Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Remove obsolete sensor/actuator properties They have never been used and are not supported in tools. Better to reintroduce them if/when we in VSS specifies recommended additional properties for e.g. security purposes or protocol adoptions. Also improving documentation based on PR review. Fixes COVESA#302 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Improve seat tilt documentation A small error was detected - when tilt is 0 seat is not parallel to X-axis, it is rather seating (seat bottom) that is parallel to Z-axis. Also minor rephrasing. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Remove pipenv parameter sequential (COVESA#496) This parameter was added to solve buildproblems some time ago. But now it has been removed and thus must be removed from our code as well Changed in pipenv v2022.9.20 pypa/pipenv@a38d153 Extend motorbike profile and include profiles in builds (COVESA#487) This PR contains some signals relevant to motorbikes. Some of them might be of general interest and may be moved to "standard vss" later. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Update vss-tools to latest version (COVESA#492) Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494) Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Enable proper search in generated documentation Previously we did not generate the JSON index required. Also bumping hugo version. Local test succesfull. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Adapt overlay documentation to implicit branches Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Extend governance and changelog information Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add tire pressure unit to HMI (COVESA#501) * Add tire pressure unit to HMI - It needs to add tire pressure unit to HMI branch because there are three different units related with tire pressure in usual. * Fix syntax error - add ':' into the end of "HMI.TirePressureUnit" * Replace allowed value strings with upper case - Replace allowed value strings with upper case Add PlaybackSpeed into Media.Played (COVESA#499) * Add PlaybackSpeed into Media.Played - It needs to add Playback Speed into Media.Played branch because it's important feature to change playback speed on some media services as audio book, youtube video * the restrictions of PlaybackSpeed the restrictions of PlaybackSpeed * Additional descriptions for meaning of the values Add text below for better understanding. comment: 1 means normal speed. <1 means slower playback than normal. >1 means faster playback than normal. * Revised with the meeting result - Aligned work with https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/playbackRate Add mute of navigation branch It is required to add date property for navigation mute. reivsed with all uppper case string Add volume property to Navigation branch (COVESA#504) * Add volume property to Navigation branch It need to have a volume property of Navigation to control the navigation guidance volume. * add unit: percent - Added unit: percent to Navigation.Volume and Media.Volume Add SmartphoneMirroring into HMI branch (COVESA#500) * Add SmartphoneMirroring into HMI branch It is required to support SmartphoneMirroring into HMI branch. Mirroring service such as AndroidAuto, AppleCarplay, and MirrorLink are broadly used in recent HMI system in the vehicle. The connectivity information for smart device such as android or iOS based phone or tablet is required for VSS. * Resolving the syntax error * Update for resolving comments * Update of naming and allowed values for projection * Reflect the comments from Erik Add HMI signals (COVESA#512) Adds two HMI-related signals existing in Android HAL but not existing in VSS FUEL_VOLUME_DISPLAY_UNITS DISPLAY_BRIGHTNESS Fix quotes for TirePressureUnit Add light switches VSS as of today has individual signals controlling/reporting if lights are on, but it does not have any signals representing the controls typically available to the driver. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Update _index.md Fixed format error in Governance page. Refactor Current Trip signals (COVESA#509) * Refactor Current Trip signals * Refactoring based on review comments Use explicit VSS units Add steering angle This adds steering angle for road wheels. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add Power Optimize concept This is a power optimization concept based on discussions in the COVESA power optimization project Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Minor editorial change Replaces COVESA#529 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Revert "Update by pulling changes from COVESA VSS master" (#2) * Revert "Minor editorial change" This reverts commit 13a3231. * Revert "Add Power Optimize concept" This reverts commit 750c4fa. * Revert "Add steering angle" This reverts commit cfbcaff. * Revert "Use explicit VSS units" This reverts commit 64cbe3a. * Revert "Refactor Current Trip signals (COVESA#509)" This reverts commit 503ef90. * Revert "Update _index.md" This reverts commit 2431461. * Revert "Add light switches" This reverts commit f19285d. * Revert "Fix quotes for TirePressureUnit" This reverts commit fce40fe. * Revert "Add HMI signals (COVESA#512)" This reverts commit 9680e49. * Revert "Add SmartphoneMirroring into HMI branch (COVESA#500)" This reverts commit b383c7d. * Revert "Add volume property to Navigation branch (COVESA#504)" This reverts commit 141b6ad. * Revert "reivsed with all uppper case string" This reverts commit 834753b. * Revert "Add mute of navigation branch" This reverts commit ff3ad34. * Revert "Add PlaybackSpeed into Media.Played (COVESA#499)" This reverts commit 65cf0be. * Revert "Add tire pressure unit to HMI (COVESA#501)" This reverts commit d198cc2. * Revert "Extend governance and changelog information" This reverts commit 027efa8. * Revert "Adapt overlay documentation to implicit branches" This reverts commit fcb9c5c. * Revert "Enable proper search in generated documentation" This reverts commit 3d0da59. * Revert "Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494)" This reverts commit 73b8e27. * Revert "Update vss-tools to latest version (COVESA#492)" This reverts commit 871503c. * Revert "Extend motorbike profile and include profiles in builds (COVESA#487)" This reverts commit 3d66406. * Revert "Remove pipenv parameter sequential (COVESA#496)" This reverts commit 47c72cd. * Revert "Improve seat tilt documentation" This reverts commit dc92ba7. * Revert "Remove obsolete sensor/actuator properties" This reverts commit 1cb3245. * Revert "Improve trunk/hood documentation (COVESA#480)" This reverts commit 354b43b. * Revert "Add low voltage battery signals" This reverts commit 0a2786c. * Revert "Buildcheck update" This reverts commit d76de94. * Revert "changed from HasDefect to IsDefect in all new files" This reverts commit 4d874c8. * Revert "Added changes from comment of erikbosch" This reverts commit ca7b84e. * Revert "deleted istances for brake and licence-plates" This reverts commit 1f1a67a. * Revert "header updated" This reverts commit a10785e. * Revert "Naming changes due to feedback" This reverts commit 50ba98f. * Revert "Changed Break to Brake and fixed wrong filenames." This reverts commit 3103ea3. * Revert "Added lights for license-plate and break-lights" This reverts commit 6a6a17a. * Revert "Feedback integrated: Comments end with '.' and file are renamed" This reverts commit 6a38da8. * Revert "Reduced number of files" This reverts commit b20f522. * Revert "added files for different types of exterior lights" This reverts commit ee184b4. * Revert "added further structuring of lights." This reverts commit 1aacf35. * Revert "Added a flag to indicate defects" This reverts commit 9c14649. * Revert "Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added" This reverts commit a3798e6. * Revert "Added vector files of logo" This reverts commit f8f1820. * Revert "Include graphql fix" This reverts commit e02d8d3. * Revert "Update dds tool" This reverts commit 7a51868. * Revert "Fix link to checklist (COVESA#474)" This reverts commit 162e893. * Revert "Update version to 3.1-develop (COVESA#472)" This reverts commit 278c0ee. * Revert "Prepare master branch for 3.0 release (COVESA#471)" This reverts commit 2e03275. * Revert "Add tar-file command to Makefile (COVESA#469)" This reverts commit a84b536. * Revert "Updated logo and color theme (COVESA#470)" This reverts commit db6f32b. * Revert "Documentation of new keyword `instantiate` (COVESA#461)" This reverts commit dc35859. * Revert "feat: Add data point Wheel.Speed" This reverts commit 93119b0. * Revert "Removed private and fixed typos" This reverts commit 4c9cef3. * Revert "Overlay documentation" This reverts commit 14dc4e4. * Revert "Remove obsolete files" This reverts commit da4eb08. fix: Address PR comments Minor editorial change Replaces COVESA#529 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> fix: Remove # from definition
jdacoello
added a commit
to jdacoello/vehicle_signal_specification
that referenced
this pull request
Apr 4, 2023
Add generic configurable light spec fix: Correct path feat: Add interactive light bar fix: Change Lights for Light (Singular) Remove obsolete files The release management picture is outdated and not used The structure.txt file does not provide much value Overlay documentation The documentation summarises idea and useage of overlays, as implemented in COVESA/vss-tools#173 Detailed documentation of the CLI will be done in tools. This just serves as an overview and background. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Removed private and fixed typos - removed private branch, as it's now handled by overlays - fixed typos. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> feat: Add data point Wheel.Speed Documentation of new keyword `instantiate` (COVESA#461) As discussed in COVESA#448 and implemented in COVESA/vss-tools#168 it gives more flexibility in defining instances. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Updated logo and color theme (COVESA#470) * added the new logo * updated color theme to blue Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Add tar-file command to Makefile (COVESA#469) Also remove obsolete deploy command and update gitignore Prepare master branch for 3.0 release (COVESA#471) Update version to 3.1-develop (COVESA#472) Fix link to checklist (COVESA#474) Update dds tool Include graphql fix Added vector files of logo Fixes: COVESA#451 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added Added a flag to indicate defects added further structuring of lights. added files for different types of exterior lights Reduced number of files Feedback integrated: Comments end with '.' and file are renamed Added lights for license-plate and break-lights Changed Break to Brake and fixed wrong filenames. Naming changes due to feedback header updated deleted istances for brake and licence-plates Added changes from comment of erikbosch changed from HasDefect to IsDefect in all new files Buildcheck update Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add low voltage battery signals Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Improve trunk/hood documentation (COVESA#480) Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Remove obsolete sensor/actuator properties They have never been used and are not supported in tools. Better to reintroduce them if/when we in VSS specifies recommended additional properties for e.g. security purposes or protocol adoptions. Also improving documentation based on PR review. Fixes COVESA#302 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Improve seat tilt documentation A small error was detected - when tilt is 0 seat is not parallel to X-axis, it is rather seating (seat bottom) that is parallel to Z-axis. Also minor rephrasing. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Remove pipenv parameter sequential (COVESA#496) This parameter was added to solve buildproblems some time ago. But now it has been removed and thus must be removed from our code as well Changed in pipenv v2022.9.20 pypa/pipenv@a38d153 Extend motorbike profile and include profiles in builds (COVESA#487) This PR contains some signals relevant to motorbikes. Some of them might be of general interest and may be moved to "standard vss" later. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Update vss-tools to latest version (COVESA#492) Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494) Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Enable proper search in generated documentation Previously we did not generate the JSON index required. Also bumping hugo version. Local test succesfull. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Adapt overlay documentation to implicit branches Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Extend governance and changelog information Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add tire pressure unit to HMI (COVESA#501) * Add tire pressure unit to HMI - It needs to add tire pressure unit to HMI branch because there are three different units related with tire pressure in usual. * Fix syntax error - add ':' into the end of "HMI.TirePressureUnit" * Replace allowed value strings with upper case - Replace allowed value strings with upper case Add PlaybackSpeed into Media.Played (COVESA#499) * Add PlaybackSpeed into Media.Played - It needs to add Playback Speed into Media.Played branch because it's important feature to change playback speed on some media services as audio book, youtube video * the restrictions of PlaybackSpeed the restrictions of PlaybackSpeed * Additional descriptions for meaning of the values Add text below for better understanding. comment: 1 means normal speed. <1 means slower playback than normal. >1 means faster playback than normal. * Revised with the meeting result - Aligned work with https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/playbackRate Add mute of navigation branch It is required to add date property for navigation mute. reivsed with all uppper case string Add volume property to Navigation branch (COVESA#504) * Add volume property to Navigation branch It need to have a volume property of Navigation to control the navigation guidance volume. * add unit: percent - Added unit: percent to Navigation.Volume and Media.Volume Add SmartphoneMirroring into HMI branch (COVESA#500) * Add SmartphoneMirroring into HMI branch It is required to support SmartphoneMirroring into HMI branch. Mirroring service such as AndroidAuto, AppleCarplay, and MirrorLink are broadly used in recent HMI system in the vehicle. The connectivity information for smart device such as android or iOS based phone or tablet is required for VSS. * Resolving the syntax error * Update for resolving comments * Update of naming and allowed values for projection * Reflect the comments from Erik Add HMI signals (COVESA#512) Adds two HMI-related signals existing in Android HAL but not existing in VSS FUEL_VOLUME_DISPLAY_UNITS DISPLAY_BRIGHTNESS Fix quotes for TirePressureUnit Add light switches VSS as of today has individual signals controlling/reporting if lights are on, but it does not have any signals representing the controls typically available to the driver. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Update _index.md Fixed format error in Governance page. Refactor Current Trip signals (COVESA#509) * Refactor Current Trip signals * Refactoring based on review comments Use explicit VSS units Add steering angle This adds steering angle for road wheels. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Add Power Optimize concept This is a power optimization concept based on discussions in the COVESA power optimization project Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Minor editorial change Replaces COVESA#529 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> Revert "Update by pulling changes from COVESA VSS master" (#2) * Revert "Minor editorial change" This reverts commit 13a3231. * Revert "Add Power Optimize concept" This reverts commit 750c4fa. * Revert "Add steering angle" This reverts commit cfbcaff. * Revert "Use explicit VSS units" This reverts commit 64cbe3a. * Revert "Refactor Current Trip signals (COVESA#509)" This reverts commit 503ef90. * Revert "Update _index.md" This reverts commit 2431461. * Revert "Add light switches" This reverts commit f19285d. * Revert "Fix quotes for TirePressureUnit" This reverts commit fce40fe. * Revert "Add HMI signals (COVESA#512)" This reverts commit 9680e49. * Revert "Add SmartphoneMirroring into HMI branch (COVESA#500)" This reverts commit b383c7d. * Revert "Add volume property to Navigation branch (COVESA#504)" This reverts commit 141b6ad. * Revert "reivsed with all uppper case string" This reverts commit 834753b. * Revert "Add mute of navigation branch" This reverts commit ff3ad34. * Revert "Add PlaybackSpeed into Media.Played (COVESA#499)" This reverts commit 65cf0be. * Revert "Add tire pressure unit to HMI (COVESA#501)" This reverts commit d198cc2. * Revert "Extend governance and changelog information" This reverts commit 027efa8. * Revert "Adapt overlay documentation to implicit branches" This reverts commit fcb9c5c. * Revert "Enable proper search in generated documentation" This reverts commit 3d0da59. * Revert "Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494)" This reverts commit 73b8e27. * Revert "Update vss-tools to latest version (COVESA#492)" This reverts commit 871503c. * Revert "Extend motorbike profile and include profiles in builds (COVESA#487)" This reverts commit 3d66406. * Revert "Remove pipenv parameter sequential (COVESA#496)" This reverts commit 47c72cd. * Revert "Improve seat tilt documentation" This reverts commit dc92ba7. * Revert "Remove obsolete sensor/actuator properties" This reverts commit 1cb3245. * Revert "Improve trunk/hood documentation (COVESA#480)" This reverts commit 354b43b. * Revert "Add low voltage battery signals" This reverts commit 0a2786c. * Revert "Buildcheck update" This reverts commit d76de94. * Revert "changed from HasDefect to IsDefect in all new files" This reverts commit 4d874c8. * Revert "Added changes from comment of erikbosch" This reverts commit ca7b84e. * Revert "deleted istances for brake and licence-plates" This reverts commit 1f1a67a. * Revert "header updated" This reverts commit a10785e. * Revert "Naming changes due to feedback" This reverts commit 50ba98f. * Revert "Changed Break to Brake and fixed wrong filenames." This reverts commit 3103ea3. * Revert "Added lights for license-plate and break-lights" This reverts commit 6a6a17a. * Revert "Feedback integrated: Comments end with '.' and file are renamed" This reverts commit 6a38da8. * Revert "Reduced number of files" This reverts commit b20f522. * Revert "added files for different types of exterior lights" This reverts commit ee184b4. * Revert "added further structuring of lights." This reverts commit 1aacf35. * Revert "Added a flag to indicate defects" This reverts commit 9c14649. * Revert "Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added" This reverts commit a3798e6. * Revert "Added vector files of logo" This reverts commit f8f1820. * Revert "Include graphql fix" This reverts commit e02d8d3. * Revert "Update dds tool" This reverts commit 7a51868. * Revert "Fix link to checklist (COVESA#474)" This reverts commit 162e893. * Revert "Update version to 3.1-develop (COVESA#472)" This reverts commit 278c0ee. * Revert "Prepare master branch for 3.0 release (COVESA#471)" This reverts commit 2e03275. * Revert "Add tar-file command to Makefile (COVESA#469)" This reverts commit a84b536. * Revert "Updated logo and color theme (COVESA#470)" This reverts commit db6f32b. * Revert "Documentation of new keyword `instantiate` (COVESA#461)" This reverts commit dc35859. * Revert "feat: Add data point Wheel.Speed" This reverts commit 93119b0. * Revert "Removed private and fixed typos" This reverts commit 4c9cef3. * Revert "Overlay documentation" This reverts commit 14dc4e4. * Revert "Remove obsolete files" This reverts commit da4eb08. fix: Address PR comments Minor editorial change Replaces COVESA#529 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com> fix: Remove # from definition Fix: Remove example allowed values from InteractiveLightBar.Effect and add info to the comment field fix: Change to DriverSide and PassengerSide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #505
Comments are welcome as it is still a bit open what is actually needed by OEMs