Skip to content

Commit

Permalink
fix: Change Lights for Light (Singular)
Browse files Browse the repository at this point in the history
Remove obsolete files

The release management picture is outdated and not used
The structure.txt file does not provide much value

Overlay documentation

The documentation summarises idea and useage of overlays,
as implemented in COVESA/vss-tools#173

Detailed documentation of the CLI will be done in tools.
This just serves as an overview and background.

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

Removed private and fixed typos

- removed private branch, as it's now handled by overlays
- fixed typos.

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

feat: Add data point Wheel.Speed

Documentation of new keyword `instantiate` (COVESA#461)

As discussed in COVESA#448 and implemented in
COVESA/vss-tools#168
it gives more flexibility in defining instances.

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

Updated logo and color theme (COVESA#470)

* added the new logo
* updated color theme to blue

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

Add tar-file command to Makefile (COVESA#469)

Also remove obsolete deploy command and update gitignore

Prepare master branch for 3.0 release (COVESA#471)

Update version to 3.1-develop (COVESA#472)

Fix link to checklist (COVESA#474)

Update dds tool

Include graphql fix

Added vector files of logo

Fixes: COVESA#451

Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>

Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added

Added a flag to indicate defects

added further structuring of lights.

added files for different types of exterior lights

Reduced number of files

Feedback integrated: Comments end with '.' and file are renamed

Added lights for license-plate and break-lights

Changed Break to Brake and fixed wrong filenames.

Naming changes due to feedback

header updated

deleted istances for brake and licence-plates

Added changes from comment of erikbosch

changed from HasDefect to IsDefect in all new files

Buildcheck update

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Add low voltage battery signals

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Improve trunk/hood documentation (COVESA#480)

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Remove obsolete sensor/actuator properties

They have never been used and are not supported in tools.
Better to reintroduce them if/when we in VSS specifies recommended
additional properties for e.g. security purposes or protocol adoptions.

Also improving documentation based on PR review.

Fixes COVESA#302

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Improve seat tilt documentation

A small error was detected - when tilt is 0 seat is not parallel to X-axis,
it is rather seating (seat bottom) that is parallel to Z-axis.
Also minor rephrasing.

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Remove pipenv parameter sequential (COVESA#496)

This parameter was added to solve buildproblems some time ago.
But now it has been removed and thus must be removed from our code as well
Changed in pipenv v2022.9.20
pypa/pipenv@a38d153

Extend motorbike profile and include profiles in builds (COVESA#487)

This PR contains some signals relevant to motorbikes.
Some of them might be of general interest and may be moved to
"standard vss" later.

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Update vss-tools to latest version (COVESA#492)

Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494)

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Enable proper search in generated documentation

Previously we did not generate the JSON index required.
Also bumping hugo version.
Local test succesfull.

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Adapt overlay documentation to implicit branches

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Extend governance and changelog information

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Add tire pressure unit to HMI (COVESA#501)

* Add tire pressure unit to HMI

- It needs to add tire pressure unit to HMI branch because there are three different units related with tire pressure in usual.

* Fix syntax error

- add ':' into the end of "HMI.TirePressureUnit"

* Replace allowed value strings with upper case

- Replace allowed value strings with upper case

Add PlaybackSpeed into Media.Played (COVESA#499)

* Add PlaybackSpeed into Media.Played

- It needs to add Playback Speed into Media.Played branch because it's important feature to change playback speed on some media services as audio book, youtube video

* the restrictions of PlaybackSpeed

the restrictions of PlaybackSpeed

* Additional descriptions for meaning of the values

Add text below for better understanding.
 comment: 1 means normal speed.
           <1 means slower playback than normal.
           >1 means faster playback than normal.

* Revised with the meeting result

- Aligned work with https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/playbackRate

Add mute of navigation branch

It is required to add date property for navigation mute.

reivsed with all uppper case string

Add volume property to Navigation branch (COVESA#504)

* Add volume property to Navigation branch

It need to have a volume property of Navigation to control the navigation guidance volume.

* add unit: percent

-  Added unit: percent to Navigation.Volume and Media.Volume

Add SmartphoneMirroring into HMI branch (COVESA#500)

* Add SmartphoneMirroring into HMI branch

It is required to support SmartphoneMirroring into HMI branch.
Mirroring service such as AndroidAuto, AppleCarplay, and MirrorLink are broadly used in recent HMI system in the vehicle.
The connectivity information for smart device such as android or iOS based phone or tablet is required for VSS.

* Resolving the syntax error

* Update for resolving comments

* Update of naming and allowed values for projection

* Reflect the comments from Erik

Add HMI signals (COVESA#512)

Adds two HMI-related signals existing in Android HAL but not existing in VSS

FUEL_VOLUME_DISPLAY_UNITS
DISPLAY_BRIGHTNESS

Fix quotes for TirePressureUnit

Add light switches

VSS as of today has individual signals controlling/reporting if lights are on,
but it does not have any signals representing the controls typically available to the driver.

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Update _index.md

Fixed format error in Governance page.

Refactor Current Trip signals (COVESA#509)

* Refactor Current Trip signals

* Refactoring based on review comments

Use explicit VSS units

Add steering angle

This adds steering angle for road wheels.

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Add Power Optimize concept

This is a power optimization concept based on discussions in the
COVESA power optimization project

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Minor editorial change

Replaces COVESA#529

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>

Revert "Update by pulling changes from COVESA VSS master" (#2)

* Revert "Minor editorial change"

This reverts commit 13a3231.

* Revert "Add Power Optimize concept"

This reverts commit 750c4fa.

* Revert "Add steering angle"

This reverts commit cfbcaff.

* Revert "Use explicit VSS units"

This reverts commit 64cbe3a.

* Revert "Refactor Current Trip signals (COVESA#509)"

This reverts commit 503ef90.

* Revert "Update _index.md"

This reverts commit 2431461.

* Revert "Add light switches"

This reverts commit f19285d.

* Revert "Fix quotes for TirePressureUnit"

This reverts commit fce40fe.

* Revert "Add HMI signals (COVESA#512)"

This reverts commit 9680e49.

* Revert "Add SmartphoneMirroring into HMI branch (COVESA#500)"

This reverts commit b383c7d.

* Revert "Add volume property to Navigation branch (COVESA#504)"

This reverts commit 141b6ad.

* Revert "reivsed with all uppper case string"

This reverts commit 834753b.

* Revert "Add mute of navigation branch"

This reverts commit ff3ad34.

* Revert "Add PlaybackSpeed into Media.Played (COVESA#499)"

This reverts commit 65cf0be.

* Revert "Add tire pressure unit to HMI (COVESA#501)"

This reverts commit d198cc2.

* Revert "Extend governance and changelog information"

This reverts commit 027efa8.

* Revert "Adapt overlay documentation to implicit branches"

This reverts commit fcb9c5c.

* Revert "Enable proper search in generated documentation"

This reverts commit 3d0da59.

* Revert "Prepare move of vspec2c and vspec2ocf to obsolete (COVESA#494)"

This reverts commit 73b8e27.

* Revert "Update vss-tools to latest version (COVESA#492)"

This reverts commit 871503c.

* Revert "Extend motorbike profile and include profiles in builds (COVESA#487)"

This reverts commit 3d66406.

* Revert "Remove pipenv parameter sequential (COVESA#496)"

This reverts commit 47c72cd.

* Revert "Improve seat tilt documentation"

This reverts commit dc92ba7.

* Revert "Remove obsolete sensor/actuator properties"

This reverts commit 1cb3245.

* Revert "Improve trunk/hood documentation (COVESA#480)"

This reverts commit 354b43b.

* Revert "Add low voltage battery signals"

This reverts commit 0a2786c.

* Revert "Buildcheck update"

This reverts commit d76de94.

* Revert "changed from HasDefect to IsDefect in all new files"

This reverts commit 4d874c8.

* Revert "Added changes from comment of erikbosch"

This reverts commit ca7b84e.

* Revert "deleted istances for brake and licence-plates"

This reverts commit 1f1a67a.

* Revert "header updated"

This reverts commit a10785e.

* Revert "Naming changes due to feedback"

This reverts commit 50ba98f.

* Revert "Changed Break to Brake and fixed wrong filenames."

This reverts commit 3103ea3.

* Revert "Added lights for license-plate and break-lights"

This reverts commit 6a6a17a.

* Revert "Feedback integrated: Comments end with '.' and file are renamed"

This reverts commit 6a38da8.

* Revert "Reduced number of files"

This reverts commit b20f522.

* Revert "added files for different types of exterior lights"

This reverts commit ee184b4.

* Revert "added further structuring of lights."

This reverts commit 1aacf35.

* Revert "Added a flag to indicate defects"

This reverts commit 9c14649.

* Revert "Restructured exterior lights to make use of instances. Enables to add addtional values per light. As example an error indicator added"

This reverts commit a3798e6.

* Revert "Added vector files of logo"

This reverts commit f8f1820.

* Revert "Include graphql fix"

This reverts commit e02d8d3.

* Revert "Update dds tool"

This reverts commit 7a51868.

* Revert "Fix link to checklist (COVESA#474)"

This reverts commit 162e893.

* Revert "Update version to 3.1-develop (COVESA#472)"

This reverts commit 278c0ee.

* Revert "Prepare master branch for 3.0 release (COVESA#471)"

This reverts commit 2e03275.

* Revert "Add tar-file command to Makefile (COVESA#469)"

This reverts commit a84b536.

* Revert "Updated logo and color theme (COVESA#470)"

This reverts commit db6f32b.

* Revert "Documentation of new keyword `instantiate` (COVESA#461)"

This reverts commit dc35859.

* Revert "feat: Add data point Wheel.Speed"

This reverts commit 93119b0.

* Revert "Removed private and fixed typos"

This reverts commit 4c9cef3.

* Revert "Overlay documentation"

This reverts commit 14dc4e4.

* Revert "Remove obsolete files"

This reverts commit da4eb08.
  • Loading branch information
jdacoello committed Feb 21, 2023
1 parent 4ad346b commit 931e5de
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions spec/Cabin/Cabin.vspec
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ RearviewMirror.DimmingLevel:
##
# Interior lights signals and sensors
##
Lights:
Light:
type: branch
description: Interior lights signals and sensors.
#include InteriorLights.vspec Lights
description: Light that is part of the Cabin.
#include InteriorLights.vspec Light


##
Expand Down
6 changes: 3 additions & 3 deletions spec/Cabin/InteriorLights.vspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@ PerceivedAmbientLight:
min: 0
max: 100
description: The percentage of ambient light that is measured (e.g., by a sensor) inside the cabin. 0 = No ambient light. 100 = Full brightness.
comment: See also Vehicle.Cabin.Lights.AmbientLight, which is used for acting on the decorative coloured lights available in the cabin.
comment: See also Vehicle.Cabin.Light.AmbientLight, which is used for acting on the decorative coloured lights available in the cabin.

LightIntensity:
datatype: uint8
type: sensor
unit: percent
min: 0
max: 100
description: Intensity of the interior lights. 0 = Off. 100 = Full brightness.
description: Intensity of the interior light. 0 = Off. 100 = Full brightness.
deprecation: V3.0 It will be removed to enable individual control of lights via the SingleConfigurableLight.vspec.
comment: Use Cabin.Lights.PerceivedAmbientLight for sensing the amount of visible light. Use SingleConfigurableLight.vspec to describe other types of interior lights that can be configured.
comment: Use Cabin.Light.PerceivedAmbientLight for sensing the amount of visible light. Use SingleConfigurableLight.vspec to describe other types of interior lights that can be configured.


#
Expand Down

0 comments on commit 931e5de

Please sign in to comment.