-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently use uid_t/gid_t for credentials #561
Open
kheaactua
wants to merge
2
commits into
COVESA:master
Choose a base branch
from
kheaactua:uid_gid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncaloalmeida
suggested changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
kheaactua
force-pushed
the
uid_gid
branch
2 times, most recently
from
December 14, 2023 16:03
1a64f38
to
40f2c8f
Compare
Rebased to 3.4.10 and forced pushed a tweak to |
It looks like I hit the Windows build error:
I'll take a look at this and push a fix. |
Hi @goncaloalmeida, PR is rebased, and all the tests pass. |
kheaactua
commented
Jan 4, 2024
Tweaked the uid/gid deserialization. |
Closed
Despite using proper types for uid/gid, the deserialization was still assuming uint32_t. This patch uses the OS's type (assuming it's 32 bits long.) This also removes the sketchy reinterpret_cast. Signed-off-by: Matthew Russell <matthew.g.russell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent use
uid_t
/gid_t
types for user/group IDs rather than sometimes usingstd::uint32_t
.We found this important in 3.1.20 and 3.3.8 on QNX, but also using these types should make vsomeip more platform independent.