You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I extended the test_constraints.py testsuite (in branch "extended_testsuite") this uncovers a range of errors related to boolean vs integer comparisons.
Bugs pop up in all solvers using the flatten transformation, so very likely this should be catched there.
As discusses offline, fixing this might have the need to introduce the unary "Not" operator to wrap around expressions instead of using == 0 to negate boolean expressions in general.
The text was updated successfully, but these errors were encountered:
IgnaceBleukx
changed the title
Boolean expression comparing with integer
Extended testsuite uncovers flatten problems
Jan 26, 2023
Yes to introducing 'Not' operator after all. And then we should take negate_normal out of flatten.py and make it a separate transformation 'negation' that pushes the negations down... will enable a few more optimisations in flatten, and eliminate the current ==0 !=1 weird checks too.
I extended the
test_constraints.py
testsuite (in branch "extended_testsuite") this uncovers a range of errors related to boolean vs integer comparisons.Bugs pop up in all solvers using the flatten transformation, so very likely this should be catched there.
As discusses offline, fixing this might have the need to introduce the unary "Not" operator to wrap around expressions instead of using
== 0
to negate boolean expressions in general.The text was updated successfully, but these errors were encountered: