Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical comparison bug whan rhs contains a multiplication #418

Closed
Wout4 opened this issue Oct 2, 2023 · 2 comments
Closed

Canonical comparison bug whan rhs contains a multiplication #418

Wout4 opened this issue Oct 2, 2023 · 2 comments
Assignees

Comments

@Wout4
Copy link
Collaborator

Wout4 commented Oct 2, 2023

Bug is located on line 273 but it is not easy to read/debug for me. Please have a look Dimos :)

iv[1] gets removed in the transformation

iv = intvar(-8,8, shape=5)
cons = [iv[2] == (iv[0] * (iv[1])) + 1]
print(cons,canonical_comparison((cons)))
@Wout4 Wout4 mentioned this issue Oct 2, 2023
@Dimosts
Copy link
Collaborator

Dimosts commented Oct 2, 2023

cons should be flattened first, before it is given to canonical_comparison.

@Wout4
Copy link
Collaborator Author

Wout4 commented Oct 2, 2023

ah i see, discovered it when testing choco so the fix there also fixes this

@Wout4 Wout4 closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants