Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reified circuit first element of list is restricted #423

Open
Wout4 opened this issue Oct 6, 2023 · 1 comment · May be fixed by #424
Open

Reified circuit first element of list is restricted #423

Wout4 opened this issue Oct 6, 2023 · 1 comment · May be fixed by #424

Comments

@Wout4
Copy link
Collaborator

Wout4 commented Oct 6, 2023

I was looking more into the MTZ decomposition of circuit, and noticed that our current implementation still has a bug:
The defining part restricts the first variable of the circuit to be in the range of the length of the list. Putting this in a negative context does not yield all possible solutions if the first variable can take values outside of this domain.

@Wout4 Wout4 self-assigned this Oct 6, 2023
@Wout4
Copy link
Collaborator Author

Wout4 commented Oct 13, 2023

it's actually for all variables, not only the first one. Proposed a fix that makes the decomposition (slightly slower)

@Wout4 Wout4 linked a pull request Oct 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant