Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HugrView::extract_hugr produces invalid hugrs #1238

Closed
aborgna-q opened this issue Jun 28, 2024 · 0 comments · Fixed by #1239
Closed

HugrView::extract_hugr produces invalid hugrs #1238

aborgna-q opened this issue Jun 28, 2024 · 0 comments · Fixed by #1239
Assignees
@aborgna-q
Labels
bug Something isn't working

Comments

@aborgna-q
Copy link
Collaborator

Root nodes must not have ports, independently of their optype.

extract_hugr disconnects the new root node, but leaves some disconnected ports causing a ValidationError::RootWithEdges.
@aborgna-q aborgna-q added the bug Something isn't working label Jun 28, 2024
@aborgna-q aborgna-q self-assigned this Jun 28, 2024
@aborgna-q aborgna-q mentioned this issue Jun 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2024
@aborgna-q
fix: extract_hugr not removing root node ports (#1239)
4c6c8cd 
Closes #1238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: extract_hugr not removing root node ports CQCL/hugr
1 participant
@aborgna-q