Feature/pr49 #50
Merged
Feature/pr49 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ollityrkko I replicated your PR here to allow the github secrets to be accessed ... |
|
@ollityrkko It looks like there is a connection error; do we need to update the credentials? |
|
I believe the problem is with the auth server URL which has changed. I made the corresponding change in README.
Auth server URL is apparently stored also in the secrets.
From: Alec Edgington ***@***.***>
Date: Tuesday, 28. March 2023 at 16.29
To: CQCL/pytket-iqm ***@***.***>
Cc: Olli Tyrkkö ***@***.***>, Mention ***@***.***>
Subject: Re: [CQCL/pytket-iqm] Feature/pr49 (PR #50)
NOTE: This e-mail originates from outside IQM, exercise caution with any instructions in the content, attachments or links.
…________________________________
@ollityrkko<https://github.com/ollityrkko> It looks like there is a connection error; do we need to update the credentials?
—
Reply to this email directly, view it on GitHub<#50 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXM526F5AYVJQBVNBFFPP2LW6LRRRANCNFSM6AAAAAAWKSHM3Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Right, thanks, I'll update the URL in the secrets... |
|
Thanks for the fixes, this looks good to me. |
cqc-melf
approved these changes
Mar 28, 2023
Yes I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.