Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error message for large classical registers #124

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

cqc-melf
Copy link
Collaborator

@cqc-melf cqc-melf commented Mar 5, 2024

Description

Solves #122

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-melf cqc-melf marked this pull request as ready for review March 5, 2024 13:59
@cqc-melf cqc-melf requested a review from cqc-alec March 5, 2024 13:59
@@ -77,7 +77,10 @@ def pytket_to_qir(

for creg in circ.c_registers:
if creg.size > 64:
raise ValueError("classical registers must not have more than 64 bits")
raise ValueError(
"""classical registers must not have more than 64 bits,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as a string without newlines.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cqc-melf cqc-melf requested a review from cqc-alec March 5, 2024 14:05
@cqc-melf cqc-melf merged commit 1685820 into develop Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants