Prefer init_reg over reg2var for empty classical registers
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - improve README - update package versions - add Makefile - resolve typos and linting issues reported by above tools - remove lark warnings from pytest output
|
Also see another option #61 |
|
Closing in favor of #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #57 and later.
I would like to use this PR for stabilizing the design of the API. For example, here are a couple options:
reg2varcompletely and keepinit_regas isreg2varfor only creating registers with initial values andinit_regfor empty cregsinit_regfor an initial value and removereg2var.PS: Please ignore changes from #58, see b3a04dd for the changes introduced in this PR.