support more multi-controlled gates in converters #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding support for general multi-controlled gates in the qiskit converters.
Note that the diff here is a bit inflated by my VScode plugin reordering the imports (forgot to disable this) hopefully it doesn't upset mypy/pylint. Let me know if I should make a fresh PR.
Changes
QControlBox
Add support for general controlled gates in converters #28Also...
4. (A suggestion) - We frequently use conditions like
if type(i) == ControlledGate
rather a lot. Shouldn't we be usingif isinstance(i, ControlledGate)
? https://switowski.com/blog/type-vs-isinstance/