Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check pytket coverage for PRs to develop. #1198

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jan 5, 2024

Description

Only do the pytket coverage check for PRs to develop. Since we are comparing with the results of the latest push to develop, this is not meaningful for PRs to other branches (e.g. main, which may be behind develop).

Also add a tolerance for random variation.

Checklist

  • I have performed a self-review of my code.

@cqc-alec cqc-alec marked this pull request as ready for review January 5, 2024 14:40
@cqc-alec cqc-alec requested a review from sjdilkes January 5, 2024 14:40
@cqc-alec cqc-alec merged commit 441e4e2 into develop Jan 8, 2024
30 checks passed
@cqc-alec cqc-alec deleted the bugfix/covdevelop branch January 8, 2024 10:29
cqc-alec added a commit that referenced this pull request Jan 17, 2024
* [infra] Fix determination of ccache path on Windows (#1192)

* Remove obsolete script. (#1179)

* Allow restriction of number of threads when building pytket using cmake. (#1180)

* Use PEP 600 manylinux containers to build pytket (#1194)

* [infra] Update versions of catch2 and rapidcheck. (#1190)

* Support python 3.12; drop python 3.9 (#1193)

* Only check pytket coverage for PRs to develop. (#1198)

* Revert "Unitary Synthesis of ChoiMixTableau for Diagonalisation (#941)"

This reverts commit ff68b3e.

Reverting because it caused significant regression in compilation
performance with
QuantinuumBackend.default_compilation_pass(optimisation_level=2) with
certain circuits composed of PauliExpBoxes.

* Bump tket version.

* Update changelog.

* Don't try to install ZX module with Python 3.12. (#1203)

* Bump tket version.

* Make the syntax of example commands more consistent between the READMEs. (#1188)

* [bugfix] Handle missing edge case in decomposition of `Rotation` (#1208)

* [feature] Accept `OpType.Phase` in circuits passed to `ZXGraphlikeOptimisation` (#1210)

* Update/copyright year (#1211)

* updtae copyright year

* update tket version

* update tket version II

* Don't build docs in release workflow. (#1212)

* Add missing `OpType.ConjugationBox` (#1209)

* Improve documentation of PassSelector. (#1214)

* Bump cachix/install-nix-action from 24 to 25 (#1216)

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 24 to 25.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](cachix/install-nix-action@v24...v25)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>

* Update version and changelog.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: David Yonge-Mallo <dlyongemallo@users.noreply.github.com>
Co-authored-by: cqc-melf <70640934+cqc-melf@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants