Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build command on Windows #1247

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fix build command on Windows #1247

merged 3 commits into from
Feb 9, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Feb 9, 2024

Description

CI builds on Windows started failing, probably because of this change to Powershell version. This fixes the issue.

Related issues

Fixes #1246 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec changed the title Bugfix/winbuild Fix build command on Windows Feb 9, 2024
@cqc-alec cqc-alec requested a review from trvto February 9, 2024 10:42
@cqc-alec cqc-alec marked this pull request as ready for review February 9, 2024 10:42
@cqc-alec cqc-alec requested a review from yao-cqc February 9, 2024 11:10
@cqc-alec cqc-alec merged commit c5a7106 into develop Feb 9, 2024
30 checks passed
@cqc-alec cqc-alec deleted the bugfix/winbuild branch February 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows builds failing on CI
3 participants