Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typechecking for JSON imports #73

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Add typechecking for JSON imports #73

merged 1 commit into from
Oct 13, 2020

Conversation

jd7h
Copy link
Contributor

@jd7h jd7h commented Oct 13, 2020

Fix for issue #25

  • add dict typechecking when JSON-loading whole lines
  • add dict typechecking for ext_tweet field in tweets

@jd7h
Add typechecking for JSON imports
e0d620b 
Fix for issue CRANE-toolbox#25

- add dict typechecking when JSON-loading whole lines
- add dict typechecking for ext_tweet field in tweets
@jd7h
Copy link
Contributor Author

jd7h commented Oct 13, 2020

By the way, your CONTRIBUTORS.MD reads

Tag your PR with "need-review" when making your initial submission or after completing the changes requested by your reviewers"

but I don't see how I can tag this PR, as I'm not a maintainer?

@IanSaucy IanSaucy added the need-review PR waiting for review label Oct 13, 2020
@LaChapeliere
Copy link
Contributor

By the way, your CONTRIBUTORS.MD reads

Tag your PR with "need-review" when making your initial submission or after completing the changes requested by your reviewers"

but I don't see how I can tag this PR, as I'm not a maintainer?

Yes, sorry, I didn't realize it would be a problem when I wrote the contributing guide. Since I want to do a complete rewriting of it, I didn't correct that mistake yet, but I should. Thanks for pointing it out (and reading CONTRIBUTING.md)!

LaChapeliere
LaChapeliere approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@LaChapeliere LaChapeliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for contributing!

@LaChapeliere LaChapeliere merged commit 84426d5 into CRANE-toolbox:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaChapeliere LaChapeliere LaChapeliere approved these changes

Assignees
No one assigned
Labels
need-review PR waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jd7h @LaChapeliere @IanSaucy