Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceleration #327

Merged
merged 15 commits into from
Feb 11, 2021
Merged

Acceleration #327

merged 15 commits into from
Feb 11, 2021

Conversation

TobiasWinchen
Copy link
Member

Implementation of first and second order Fermi acceleration.

The code is documented in the new notebooks in the doc directory:
https://github.com/TobiasWinchen/CRPropa3/blob/acceleration/doc/pages/example_notebooks/acceleration

While integrating the examples I slightly restructured and streamlined the existing documentation.

@TobiasWinchen TobiasWinchen added this to the 3.2 milestone Jan 31, 2021
doc/pages/acceleration.rst Outdated Show resolved Hide resolved
doc/pages/acceleration.rst Outdated Show resolved Hide resolved
doc/pages/acceleration.rst Outdated Show resolved Hide resolved
@TobiasWinchen
Copy link
Member Author

Thanks for your comments, I updated the spelling + coding style accordingly.

@adundovi
Copy link
Member

adundovi commented Feb 4, 2021

Hi Tobi, it is OK from my side. However, I checked it on a technical level only, not equations and physics, yet I assume you test this carefully.

@rafaelab
Copy link
Member

rafaelab commented Feb 4, 2021

I am still testing this. I will merge the PR once I'm done (probably early next week).
I'm just concerned that some combinations of energy losses and energy gains might mess things up, so I'm testing some limiting cases. I haven't found anything so far.
Btw, great work, @TobiasWinchen !

@rafaelab
Copy link
Member

rafaelab commented Feb 9, 2021

@TobiasWinchen I have finished reviewing the PR and testing the module. I have no more comments.
Let's just wait until 3.1.7 is released on Friday, and then we can merge your PR, since this is a feature of 3.2.

@rafaelab
Copy link
Member

Ready to be merged.
@TobiasWinchen : just make sure to add the relevant information to the Change Log before merging.

@rafaelab rafaelab merged commit 7a0a991 into CRPropa:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants