Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt for macos installing #437

Closed
wants to merge 1 commit into from
Closed

Conversation

cxwx
Copy link

@cxwx cxwx commented Aug 8, 2023

for #390

@lukasmerten
Copy link
Member

Can someone of the Mac users quickly check this? Looks in general fine to me, but I cannot test it.

@rafaelab
Copy link
Member

Thanks, @cxwx
But this doesn't work for me. I get the error message

CMake Error at /opt/homebrew/Cellar/cmake/3.25.2/share/cmake/Modules/FindPkgConfig.cmake:663 (message):
  pkg-config tool not found
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.25.2/share/cmake/Modules/FindPkgConfig.cmake:829 (_pkg_check_modules_internal)
  CMakeLists.txt:230 (pkg_check_modules)

I also fail to see the underlying logic for requiring profiler, as this is not needed to run CRPropa.
After some quick search in google this problem (#390) seems to be related to Google performance tools, which is also not a requirement for CRPropa. According to this discussion, this happens when gperf is installed via brew, so it doesn't seem to be a general problem.

@lukasmerten
Copy link
Member

I close this PR for now. If you, @cxwx, think it is still relevant, please reopen this or a new PR.

@lukasmerten lukasmerten closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants