Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation of OSGi metadata and JPMS module-info #11

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

fipro78
Copy link
Contributor

@fipro78 fipro78 commented Jun 7, 2024

As per our discussion in osgi/osgi#631 I am working on a more useful example of a containerized OSGi application. I want to setup a REST service application using Jakarta RS Whiteboard and put that in a container with checkpoint data.

While trying to create a Resource to handle the checkpoint/restore operations (see eclipse-osgi-technology/jakartarest-osgi@2ac4d8f) I noticed that org.crac does not contain OSGi metadata. It is therefore not possible to use it easily.

The following PR adds the necessary build step to add OSGi metadata to the jar file. Additionally it also adds a JPMS module-info.class to the jar. Once this is merged and released I can move on with a PR for the Jakarta-RS Whiteboard, and then provide the example for CRaC`in an OSGi application.

@AntonKozlov
Copy link
Member

Hi @fipro78, thanks a lot for the contribution!

I've tested that with JDK 8 just in case, and it looks fine.

Thanks!

@fipro78
Copy link
Contributor Author

fipro78 commented Jun 19, 2024

@AntonKozlov
Any plans for a release with OSGi metadata? I'm preparing an example and would like to use an official version for the documentation instead of a locally build variant.

@AntonKozlov
Copy link
Member

Thanks for reminding, the version 1.5.0 is released. Apparently it did not propagte to the Maven Central, but should be on its way.

Sorry, it took a while to adapt to new maven central policies.

@fipro78
Copy link
Contributor Author

fipro78 commented Jun 19, 2024

Thanks, I will test it and update my example once it is available in Maven Central.

@AntonKozlov
Copy link
Member

@fipro78
Copy link
Contributor Author

fipro78 commented Jun 20, 2024

Thanks a lot! I already updated my example locally and it looks fine.

BTW, I noticed some issues or at least have questions about the OpenJDK implementation that is provided by Azul. Where should I raise such questions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants