-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create 'downloadLink' asset #1270
Conversation
it works in library mode for 'get' download method with 'HTTPDownload' plugin with provider that can contains single assets and the 'downloadLink' asset at the same time
Test Results 4 files ± 0 4 suites ±0 5m 44s ⏱️ -33s For more details on these failures and errors, see this check. Results for commit 221f846. ± Comparison against base commit a456422. ♻️ This comment has been updated with latest results. |
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 221f846 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)
Diff against develop
Results for commit: 221f846 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
0fdac93
to
221f846
Compare
not fan of this approach. In library mode, we'd better keep working with |
Fixes #1042
Create a
downloadLink
asset:downloadLink
property is got with a json path, it is kept to use it asdownloadLink
assethref
downloadLink
property is given with a link, we can remove it and place this link directly in thedownloadLink
assethref
For now, it works in library mode for 'get' download method with
HTTPDownload
plugin with provider that can contains single assets and thedownloadLink
asset at the same time".