fix(server): invalid characters in download urls #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage (Ubuntu)Diff against developResults for commit: e3c654f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Code Coverage (Windows)Diff against developResults for commit: e3c654f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
dalpasso
requested changes
Jul 29, 2024
There was a problem hiding this comment.
The path should be quoted also in the links section of the item:
"links": [
{
"rel": "self",
"title": "W_XX-EUMETSAT-Darmstadt,HYPERSPECT+SOUNDING,METOPA+PW3+IASI_C_EUMP_20070710090558Z_20070710104454Z_eps_r_l2_0101",
"href": "http://localhost:5000/collections/METOP_IASTHR011/items/W_XX-EUMETSAT-Darmstadt,HYPERSPECT+SOUNDING,METOPA+PW3+IASI_C_EUMP_20070710090558Z_20070710104454Z_eps_r_l2_0101"
},
{
"rel": "root",
"href": "http://localhost:5000/"
},
{
"rel": "parent",
"title": "METOP_IASTHR011",
"href": "http://localhost:5000/collections/METOP_IASTHR011"
},
{
"rel": "collection",
"title": "METOP_IASTHR011",
"href": "http://localhost:5000/collections/METOP_IASTHR011"
}
],
urls in links are now also quoted |
dalpasso
approved these changes
Jul 29, 2024
sbrunato
approved these changes
Aug 9, 2024
sbrunato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the path part of the "href" values of the assets is now quoted to avoid invalid characters in the urls, e.g. due to commas in the id which occur for some collections of the
eumetsat_dsprovider (METOP_AVHRRGACR02andMETOP_IASTHR011)