Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1.3] Contacts: Added findphone, findname and findaddress commands #72

Merged
merged 11 commits into from
Oct 22, 2018

Conversation

T0roloco
Copy link

No description provided.

@QzSG
Copy link

QzSG commented Oct 21, 2018

@T0roloco Mind resolving the conflict? Not sure which one is the correct one u need

@T0roloco
Copy link
Author

@T0roloco Mind resolving the conflict? Not sure which one is the correct one u need

@QzSG Hmm...strange. For some reason I don't have the line:

         commandList.add(FindCommand.COMMAND_WORD + " KEYWORD");

in my version of main. Not really what that line does, not sure what do do here. Should I try to update my version of main and just copy the classes I've created? I haven't done tests for those classes yet, but the commands I added work as intended

@T0roloco
Copy link
Author

Btw I'm pretty sure the FindCommand class can be deleted since i added the other commands. I just decided not to since I'm thinking of creating a superclass and make the other three subclasses

@coveralls
Copy link

coveralls commented Oct 21, 2018

Pull Request Test Coverage Report for Build 117

  • 3 of 54 (5.56%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 70.527%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/AddressBookParser.java 0 3 0.0%
src/main/java/seedu/address/logic/parser/FindAddressCommandParser.java 0 7 0.0%
src/main/java/seedu/address/logic/parser/FindNameCommandParser.java 0 7 0.0%
src/main/java/seedu/address/logic/parser/FindPhoneCommandParser.java 0 7 0.0%
src/main/java/seedu/address/logic/commands/FindAddressCommand.java 0 9 0.0%
src/main/java/seedu/address/logic/commands/FindNameCommand.java 0 9 0.0%
src/main/java/seedu/address/logic/commands/FindPhoneCommand.java 0 9 0.0%
Totals Coverage Status
Change from base Build 116: -1.7%
Covered Lines: 1498
Relevant Lines: 2124

💛 - Coveralls

QzSG
QzSG approved these changes Oct 22, 2018
@QzSG QzSG added this to the v1.3 milestone Oct 22, 2018
Copy link

@QzSG QzSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Would be nice to add some unit tests in future pull requests so that we can be sure adding these commands did not break the others (also that it works as expected).

Some of the predicate methods look similar, once you are done with everything else and if there is time maybe you could look into making them more generic, for now its okay!

(Bypassing strict checks since Github outage stops webhooks from being sent so travis could not run build & tests but AppVeyor passed)

@QzSG QzSG merged commit f36532f into CS2113-AY1819S1-T13-1:master Oct 22, 2018
@QzSG
Copy link

QzSG commented Oct 22, 2018

Relevant #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants