-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1.3] Contacts: Added findphone, findname and findaddress commands #72
Conversation
@T0roloco Mind resolving the conflict? Not sure which one is the correct one u need |
@QzSG Hmm...strange. For some reason I don't have the line:
in my version of main. Not really what that line does, not sure what do do here. Should I try to update my version of main and just copy the classes I've created? I haven't done tests for those classes yet, but the commands I added work as intended |
Btw I'm pretty sure the FindCommand class can be deleted since i added the other commands. I just decided not to since I'm thinking of creating a superclass and make the other three subclasses |
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
…dupdate trying to push userguide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now. Would be nice to add some unit tests in future pull requests so that we can be sure adding these commands did not break the others (also that it works as expected).
Some of the predicate methods look similar, once you are done with everything else and if there is time maybe you could look into making them more generic, for now its okay!
(Bypassing strict checks since Github outage stops webhooks from being sent so travis could not run build & tests but AppVeyor passed)
Relevant #63 |
No description provided.